Skip to content

Update libs#2832

Merged
abelgardep merged 4 commits into
masterfrom
UpdateLibs
Jun 4, 2020
Merged

Update libs#2832
abelgardep merged 4 commits into
masterfrom
UpdateLibs

Conversation

@hannesa2
Copy link
Copy Markdown
Contributor

@hannesa2 hannesa2 commented Mar 5, 2020

It's only to be up to date and raise problems as soon an possible.
Waiting to long makes things not easier.

@jesmrec jesmrec added this to the 3.0-next milestone Mar 6, 2020
@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Mar 7, 2020

Bitrise ! What should I say ?
image

image

And to be honest, I'm not interested in having an additional Bitrise account.
I made you a better solution #2816 but this Espresso test are flake and not trust able like they are in current state

@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Mar 7, 2020

And when I do local a ./gradlew :owncloudApp:lint on master I run into
image

This shows me, that you probably not perform a lint check in Bitrise. But I can't verify 👎
The solution is #2816 and to be honest iOS and Android don't need always the same tools. You only collect the disadvantages from both systems. You could throw this paradigm to the waste basket @michaelstingl

@abelgardep
Copy link
Copy Markdown
Contributor

Hi @hannesa2, first of all, thanks for your contributions.

We perform a lint check in Bitrise, that's why this pr failed.
I need to research a little bit about GitHub Actions to check if it is viable. At the moment, bitrise is working for us, so we won't change if github actions don't.

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jun 4, 2020

I have performed a smoke test over the branch and worked fine. Any additional suggestion for testing the stuff here @abelgardep ?

@abelgardep
Copy link
Copy Markdown
Contributor

Not at all. Just updating libraries and fixing lint errors.

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Jun 4, 2020

Ok, then it is approved, Please fix conflicts and move forward

@abelgardep abelgardep merged commit c556683 into master Jun 4, 2020
@abelgardep abelgardep deleted the UpdateLibs branch June 4, 2020 11:51
@abelgardep
Copy link
Copy Markdown
Contributor

Merged, thanks @hannesa2 👍

@jesmrec jesmrec removed the Sprint label Jun 5, 2020
@jesmrec jesmrec modified the milestones: 2.16-current, 2.15.2 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants