ci: accept CVE-2026-56854 for the bundled rclone binary - #62
Merged
Conversation
The Trivy scan started failing without a code change: CVE-2026-56854 was added to the vulnerability database between the runs of 2026-08-31 and 2026-09-01. The same tree that passed on 2026-08-31 failed the next morning, on master and on every open pull request. This is exactly the case the weekly schedule was added for. bin/rclone_linux_amd64 is upstream rclone v1.75.0, which vendors golang.org/x/crypto v0.54.0; the fix is in v0.55.0. It is CRITICAL with a fix available, so it passes the HIGH,CRITICAL + ignore-unfixed gate and fails the job. There is nothing to upgrade to yet: v1.75.0 (2026-07-31) is still the newest rclone release, so no rclone binary available today is free of this finding. rclone master already carries x/crypto v0.55.0, so this clears with the next release rather than with a go toolchain bump - which is why the entry is kept apart from the eight stdlib ones, whose drop condition is a different one. Rebuilding a patched binary ourselves is not an option we want: #56 deliberately replaced the custom fork with an upstream release. The flaw is not reachable from this app. It is in the SSH server handshake (ssh.NewServerConn / connection.serverAuthenticate), where a source-address restriction returned by a password, keyboard-interactive, no-client-auth or GSSAPI callback went unenforced, so it needs an inbound SSH connection to an SSH server. This app shells out to `rclone sync` between two WebDAV remotes over HTTPS and to `rclone obscure`; it never uses the sftp backend or `rclone serve`. Verified with trivy v0.74.0 against the same layout the workflow scans: the finding reproduces before the change and is gone after it, and backdating expired_at re-reports all nine entries, so this acceptance still expires on 2026-11-01. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <169163068+ThomasMuellerKiteworks@users.noreply.github.com>
phil-davis
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Trivy scan started failing without a code change:
CVE-2026-56854was added to the vulnerability database between the runs of 2026-08-31 and 2026-09-01. The same tree that passed on 2026-08-31 failed the next morning — on master and on every open pull request. This is exactly the case the weekly schedule was added for in #59.bin/rclone_linux_amd64is upstream rclone v1.75.0, which vendorsgolang.org/x/crypto v0.54.0; the fix is in v0.55.0. It is CRITICAL with a fix available, so it passes theHIGH,CRITICAL+ignore-unfixedgate and fails the job.Why an accepted entry rather than an upgrade
x/crypto v0.55.0. That is a different drop condition from the eight stdlib entries (which wait on go >= 1.26.6), so the entry is kept apart from them with its own note.Why it is not reachable here
The flaw is in the SSH server handshake (
ssh.NewServerConn/connection.serverAuthenticate), where a source-address restriction returned by a password, keyboard-interactive, no-client-auth or GSSAPI callback went unenforced. It needs an inbound SSH connection to an SSH server.This app never starts one: it shells out to
rclone syncbetween two WebDAV remotes over HTTPS and torclone obscure(lib/MigrationState/StateMigrateFiles.php), and never uses the sftp backend orrclone serve.Verification
Ran trivy v0.74.0 against the same layout the workflow scans:
Total: 1 (CRITICAL: 1), exit 1 — matches the CI output exactly0findings, exit 0expired_atre-reports all nine entries, so this acceptance still expires on 2026-11-01 rather than silently outliving its review dateNo changelog entry, matching #59 (also scan-only).
🤖 Generated with Claude Code