Skip to content

Only pull in one version of Instructure UI - #54

Merged
buckett merged 1 commit into
mainfrom
instructure-ui-version-fix
Jun 5, 2026
Merged

Only pull in one version of Instructure UI#54
buckett merged 1 commit into
mainfrom
instructure-ui-version-fix

Conversation

@buckett

@buckett buckett commented Jun 4, 2026

Copy link
Copy Markdown
Member

We prefer to have everything share the same version of Instructure UI rather than some libraries getting their own version of the packages.

Copilot AI review requested due to automatic review settings June 4, 2026 15:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an npm configuration to encourage dependency deduplication so the project is less likely to install multiple copies/versions of Instructure UI packages, and it ensures that config is committed to the repo.

Changes:

  • Add a committed .npmrc setting prefer-dedupe=true with rationale comments.
  • Stop ignoring .npmrc in .gitignore so the setting is shared across installs.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
.npmrc Adds prefer-dedupe=true to encourage a single dependency tree for Instructure UI packages.
.gitignore Removes .npmrc from ignored files so the npm config is tracked.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .npmrc
@buckett
buckett force-pushed the instructure-ui-version-fix branch from e41d993 to 681096d Compare June 5, 2026 08:13
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploying account-reports with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed9c79e
Status: ✅  Deploy successful!
Preview URL: https://37c094ea.account-reports.pages.dev
Branch Preview URL: https://instructure-ui-version-fix.account-reports.pages.dev

View logs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

We prefer to have everything share the same version of Instructure UI rather than some libraries getting their own version of the packages.
@buckett
buckett force-pushed the instructure-ui-version-fix branch from 681096d to ed9c79e Compare June 5, 2026 08:26
@buckett
buckett merged commit 631dfc3 into main Jun 5, 2026
1 check passed
@buckett
buckett deleted the instructure-ui-version-fix branch June 5, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants