Skip to content

AB#126691 Correctly pickup changes to options. - #303

Merged
buckett merged 1 commit into
masterfrom
AB#126691
Jun 16, 2026
Merged

AB#126691 Correctly pickup changes to options.#303
buckett merged 1 commit into
masterfrom
AB#126691

Conversation

@buckett

@buckett buckett commented Jun 11, 2026

Copy link
Copy Markdown
Member

We move all the OptionSettings from the template to the actual environment. This means changes to the values are picked up. The template is only consulted when a new environment is created.

We move all the OptionSettings from the template to the actual environment. This means changes to the values are picked up. The template is only consulted when a new environment is created.
Copilot AI review requested due to automatic review settings June 11, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Elastic Beanstalk environment CloudFormation template to introduce a dedicated AWS::ElasticBeanstalk::ConfigurationTemplate resource (EnvironmentTemplate) and updates the environment to reference it via TemplateName.

Changes:

  • Added a new EnvironmentTemplate (AWS::ElasticBeanstalk::ConfigurationTemplate) resource.
  • Updated the Environment resource to reference the new configuration template (TemplateName: !Ref EnvironmentTemplate).
  • Removed the previous appConfigTemplate configuration template resource block (effectively a rename/restructure).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread aws/eb-env.yaml
Comment on lines +248 to +261
EnvironmentTemplate:
Type: AWS::ElasticBeanstalk::ConfigurationTemplate
Properties:
ApplicationName: !Ref appName
Description: !Sub "Config template - ${appName}"
SolutionStackName: !Ref solutionStack

Environment:
Type: "AWS::ElasticBeanstalk::Environment"
Properties:
EnvironmentName: !Sub "${appName}-${envType}"
ApplicationName: !Ref appName
VersionLabel: !Ref ApplicationVersion
TemplateName: !Ref appConfigTemplate
TemplateName: !Ref EnvironmentTemplate
Comment thread aws/eb-env.yaml
Comment on lines +245 to +247
# We use a configuration template so that at environment creation the correct solution stack is used,
# but then we can update the value supplied to the stack later and nothing changes (but the stack still deploys).
# Only when the managed updates are applied will the solution stack be updated.
Comment thread aws/eb-env.yaml
Comment on lines +248 to 266
EnvironmentTemplate:
Type: AWS::ElasticBeanstalk::ConfigurationTemplate
Properties:
ApplicationName: !Ref appName
Description: !Sub "Config template - ${appName}"
SolutionStackName: !Ref solutionStack

Environment:
Type: "AWS::ElasticBeanstalk::Environment"
Properties:
EnvironmentName: !Sub "${appName}-${envType}"
ApplicationName: !Ref appName
VersionLabel: !Ref ApplicationVersion
TemplateName: !Ref appConfigTemplate
TemplateName: !Ref EnvironmentTemplate
Tier:
Name: "WebServer"
Type: "Standard"
Version: "1.0"

appConfigTemplate:
Type: AWS::ElasticBeanstalk::ConfigurationTemplate
Properties:
ApplicationName: !Ref appName
SolutionStackName: !Ref solutionStack
Description: !Sub "Config template - ${appName}"
OptionSettings:
@buckett
buckett merged commit 3421410 into master Jun 16, 2026
2 checks passed
@buckett
buckett deleted the AB#126691 branch June 16, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants