Skip to content

AB#113348 Remove ssh options to drop security groups. - #305

Merged
buckett merged 1 commit into
masterfrom
AB#113348
Jun 29, 2026
Merged

AB#113348 Remove ssh options to drop security groups.#305
buckett merged 1 commit into
masterfrom
AB#113348

Conversation

@buckett

@buckett buckett commented Jun 26, 2026

Copy link
Copy Markdown
Member

This also changes the deployment options so it will deploy correctly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Elastic Beanstalk environment configuration to remove SSH-related options (to avoid SSH/security-group side effects) and to adjust deployment/rolling update settings so deployments succeed in the intended environment modes.

Changes:

  • Increased the Auto Scaling Group MaxSize from 1 to 2.
  • Removed SSH-related EB options (SSHSourceRestriction, DefaultSSHPort).
  • Changed rolling/deployment behavior (RollingUpdateType: Health, prod DeploymentPolicy: RollingWithAdditionalBatch).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread aws/eb-env.yaml Outdated
Comment on lines +331 to +334
- ResourceName: "AWSEBAutoScalingGroup"
Namespace: "aws:autoscaling:asg"
OptionName: "MaxSize"
Value: "1"
Value: "2"
@buckett

buckett commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

I've been having more problems deploying this, so have just been updating through CLI.

@buckett
buckett requested a review from lardo-de-arnaud June 29, 2026 13:17
@lardo-de-arnaud

Copy link
Copy Markdown
Contributor

after looking, I'm not sure I am the best person to review.

@buckett
buckett merged commit f2975a0 into master Jun 29, 2026
2 checks passed
@buckett
buckett deleted the AB#113348 branch June 29, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants