[nexus-external-api] reorganize per RFD 619#9568
Draft
sunshowers wants to merge 11 commits intomainfrom
Draft
Conversation
Created using spr 1.3.6-beta.1
25 tasks
Created using spr 1.3.6-beta.1
Contributor
Author
|
@david-crespo one of the things we determined in RFD 619 is that we organize types by semantic area rather than params/views/shared. This makes sense for internal APIs but would love your thoughts on this when applied to the external API (I can put things back in params/views/shared if desired, but wanted your thoughts on the complete migration). |
Contributor
Contributor
|
Thinking more about it, I'm fine with it. It's nice to have smaller files and it's nice to have things grouped thematically. If we're worried about confusing models and views in a particular case, we can always import with an alias or something. |
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is an extremely large PR, but a generally quite mechanical one. I had Claude Code both write most of the PR and review it for conformance with the RFD -- all tests appear to pass, and I also manually spot-checked the versions crate to ensure it generally made sense.