Skip to content

Don't print a confusing error on auto-open failure #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Jul 8, 2026
Merged

Don't print a confusing error on auto-open failure #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,8 @@ if (opts.dev) {
const url = `http://localhost:${apiPort}`
const { cmd, args } = urlOpenCommand(url)
const opener = spawn(cmd, args, { detached: true, stdio: 'ignore' })
opener.on('error', (err) => {
console.error(`Could not open URL with ${cmd}: ${err.message}`)
console.error(`Open ${url} to see the diff`)
})
// The URL is already printed on server startup, so a failed opener (e.g. no
// xdg-open on illumos) needs no message — swallow the error and carry on.
opener.on('error', () => {})
opener.unref()
}
Loading