Repository navigation
fix(gui): release cache waits for materialized previews - #286
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a native history refresh preserves existing preview bytes alongside an incoming preview cache key, Status and channel previews could wait indefinitely for a cache read that the materialization scheduler would never admit. Use the scheduler's reference eligibility rule for UI wait decisions, and make Status use the same failure-aware wait predicate. A full cache key still receives its local attempt; missing full files release the wait without discarding the existing preview.
Follow-up to merged #284 and its Codex P2 finding. Based on current main
39fca7f; no changes to the merged branch.Reproduction uses synthetic rows and the real
Chat::insert_history_messagepath: retain preview bytes, refresh an empty row carrying onlypreview_cache_key, then check scheduling and wait decisions. The new regression test fails on main before this fix. A second test covers reopened image/video status, full-cache eligibility, failure release, and preview preservation.Validation on
2507412:-D warnings: passed.This is a correctness follow-up; no new performance claim or real-account measurement. Remote CI and automatic review are pending.
Summary by cubic
Fixes Status and channel previews waiting indefinitely for a cache read that the materialization scheduler would never admit, which happened when a history refresh preserved existing preview bytes but introduced a new preview cache key. Wait decisions now use the scheduler's reference eligibility rule, and Status uses the same failure-aware predicate.
Written for commit 2507412. Summary will update on new commits.