Skip to content

feat(protocol): update WhatsApp snapshot and compact codegen - #1827

Merged
jlucaso1 merged 15 commits into
mainfrom
feat/whatspec-23000-1052559453
Nov 1, 2026
Merged

jlucaso1 merged 15 commits into
mainfrom
feat/whatspec-23000-1052559453

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Update WhatsApp from 2.3000.1047483476 to 2.3000.1052559453 using whatspec IR 4.5.0, and reduce the source and fixture cost of future upgrades. Pin integrated whatspec main commit ae3880925bacd23863cc30ec480c9f82bfd869f1, merged by oxidezap/whatspec#65. Its complete tree is identical to the qualified head afa3e343; the upstream dependency is resolved.

The cleanup reduces this upgrade's source-tree growth from 1,332,237 to 57,146 bytes (95.7%) and the PR from 102 to 92 files. The one-time WAM representation rewrite increases gross patch churn, detailed below.

  • Regenerate all 24 artifacts. Adapt exclusive IQ alternatives and group RPC modules; preserve handwritten support when a client builder disappears.
  • Preserve group warning/error/read order, null results and source-node alignment. Read participant history without the old CREATE flag and use the effective account window directly.
  • Keep the frozen protobuf API through guarded string/fixed32 wallpaper wire dispatch. Preserve the historical MEX query, 12 MEX field/list shapes, two WAM events, five WAM enums, 32 WAM fields, 26 platform variants and 82 public flag imports.
  • Keep all useful current captures and compatibility regressions. Remove ten unconsumed historical fixtures, two task reports and duplicate unused evidence. All ten historical files were byte-identical to the corresponding baseline files; no code/test consumer remains. Historical public contracts stay covered by focused compilation, serialization and wire regressions.
  • Share 28 observed normalization outcomes across all 204 inputs. The complete expanded oracle must retain canonical SHA-256 5d114fc5756c40cbe15fd221c0f40896e02087aec2cdfb5a30dd39887a9c25d5. Payloads, reads, warnings and case order are retained; a mutation regression rejects changed observations, invalid references or lost cases.
  • Emit one normalization test executor and private const constructors for WAM parity metadata. Every public CALL_SITES value was compared equal to 9ecd1fb5 using the existing derived equality, including every event/code/field/site/module/partiality/write kind. The data and public types are unchanged.

Audit against baseline 0d1373a8, with 9ecd1fb5 as the pre-cleanup checkpoint:

Measure Before cleanup After cleanup
PR files 102 92
Added lines 45,732 45,423
Deleted lines 5,862 58,734
Net lines +39,870 -13,311
Gross changed lines (adds + deletes) 51,594 104,157
Source-tree growth +1,332,237 B +57,146 B

The upgrade's source-tree growth is 95.7% lower: 1,275,091 bytes removed from the current tree. This does not measure Git pack size, runtime memory or binary size. The first WAM representation migration rewrites existing rows, so this PR's gross patch churn increases even though net lines and the final source tree shrink. Future captures use the compact emitter directly; this is a one-time representation migration. Earlier committed bytes remain in Git history; no history rewrite or force-push was used. Identical historical blobs may already have been deduplicated by Git.

Main consolidation Before After
WAM parity source 1,752,293 B / 57,670 lines 919,994 B / 20,226 lines
Generated normalization test 168,549 B / 4,480 lines 21,732 B / 752 lines
Complete normalization oracle 109,923 B / 5,500 lines 22,473 B / 844 lines
Ten unused historical fixtures 155,773 B removed
Two task reports 38,508 B removed

Future upgrades reuse the current fixture paths, shared outcome table and test executor. They do not copy a complete prior snapshot or add task chronology to product sources. The operational capture lock retains immutable upstream evidence and archive URLs/digests; regular tests and generation can use the pinned local IR without network. No whatspec changes were needed for this cleanup.

Reproduce:

cargo run -p whatspec-codegen -- --check --from ../whatspec/generated --verify-iq-contextual ../whatspec/generated
node tools/whatspec-codegen/fixtures/capture-group-normalization.cjs ../whatspec --check
cargo nextest run -p whatspec-codegen
cargo nextest run -p wacore --lib stanza::groups
cargo nextest run -p whatsapp-rust-wam-catalog --features parity

Local validation: 151 generator tests, 86 group tests, 21 catalog tests plus the one-off full old/new parity equality comparison, deterministic regeneration, capture reproduction and all-target generator/catalog Clippy passed. The capture digest regression also passed with serde_json/preserve_order enabled; object keys are explicitly canonicalized. The independent original-JS harness still reproduces 64 actions, 29 envelopes, 13 CREATE and 204 normalization cases, rejecting eight IR mutations. The main CI job passed 7,908 tests (41 skipped), 18 focused persistence tests and doctests. Remaining CI/reviews are being validated on c6b27efc1d56625829f9c0caa0228b66377af177; results from earlier heads are historical. No authenticated WhatsApp session was exercised.

Binary-size qualification before cleanup was stripped +60.25 KiB and text +59.31 KiB against 0d1373a8 with identical rustc; most growth was protobufs (waproto +51,186 B). The existing size-increase-ok policy applies; global budgets are unchanged. Source compaction is not a binary-size or performance claim.

Performance qualification remains separate and unresolved. Pre-cleanup CodSpeed run 6ae6e99f reported connect_to_ready 175.6 → 206.1 ms modeled CPU (-14.77% reported efficiency), with different hardware and significant excluded syscall time. A slower profile included ~21.4 ms of prekey/session and AppState key-share work absent from a faster upgraded sample; causality and production latency are not established. Pulling the exact image ghcr.io/whiskeysockets-devtools/bartender@sha256:9f3a49dd9f944414fbda50571bba5f66f2ab6fdc48001e6803d4c09a1042c78e returned registry DENIED; no image or container was obtained. Existing credentials lack read:packages, and the authorized CI workflow has no paired walltime comparison input. No credentials were expanded, denied access retried, alternate image used, alert waived or threshold changed. Controlled base/head walltime on an already-authorized executor remains required.

Current-head CodSpeed run 6ae728b523410ee24cdcd569 completed SUCCESS at c6b27efc1d56625829f9c0caa0228b66377af177: zero regressions, four improvements and 940 unchanged comparisons. connect_to_ready is 176.543 ms modeled CPU versus 175.633 ms in the base, classified unchanged; 549 syscalls and 9.564 s of syscall time are excluded. The four walltime improvements crossed different hardware and are not attributed to this patch. The historic 206–208 ms observation did not recur in this run; this does not establish causality or controlled production latency. No threshold, archive state or alert acknowledgment changed. The source-size reductions above are measured independently of performance.

The first all-feature job (124839539048) failed because GitHub reported that the hosted runner lost communication during the build; its build step has no completion and the log blob is unavailable. The single isolated retry job 124851629256 passed the build, Clippy and every shareable-feature test. No code, resources or validation criteria were changed for the retry.

Keep draft pending final-head validation, human review and controlled performance qualification. No core merge, release or deployment.

Reproduce the one-off complete WAM representation comparison

This checks the migration without retaining a second catalog snapshot in the repository or adding network-dependent tests. In a checkout containing ancestor 9ecd1fb51a7227cccd5f87d931399e87bb9791e2, extract its source to plugins/wam-catalog/tests/migration/before.rs:

git show 9ecd1fb51a7227cccd5f87d931399e87bb9791e2:plugins/wam-catalog/src/call_sites.rs

Temporarily create plugins/wam-catalog/tests/compare_parity.rs:

#![cfg(feature = "parity")]
use whatsapp_rust_wam_catalog::{CallSite, CallSiteField, CatalogField, EventCallSites, FieldWrite};
#[path = "migration/before.rs"]
mod before;
#[test]
fn all_parity_metadata_is_identical() {
    assert_eq!(before::CALL_SITES, whatsapp_rust_wam_catalog::call_sites::CALL_SITES);
}

Run cargo nextest run -p whatsapp-rust-wam-catalog --features parity --test compare_parity, then discard only these temporary comparison files. The permanent catalog tests and current generated metadata remain; no previous snapshot is added to normal tests.

File-by-file inventory and disposition (104 path identities, including both sides of two original renames)

Compared with pre-cleanup 9ecd1fb5. Lines and bytes are complete file sizes, not patch counts. Paths that were already absent at that checkpoint show zero. CG/ means tools/whatspec-codegen/; GR/ means wacore/src/stanza/groups/.

K: Keep consumed output or focused regression. P: Keep historical public API and identity guards. G: Keep generator/lock and drift guards. D: Keep permanent compact-upgrade instructions. W: Compact WAM representation; identical typed metadata. O: Share outcomes; preserve all 204 cases and canonical digest. T: One table/executor; preserve assertions. L: Keep compact operational source lock. H: Remove unconsumed baseline duplicate. R: Remove task report; summary retained here. U: Remove redundant unused evidence. X: Replace obsolete standalone oracle with current complete matrix.

File Role Lines before → after Bytes before → after Decision
Cargo.lock tooling lock 5977 → 5977 143669 → 143669 K
agent_docs/codegen.md documentation 133 → 144 8758 → 9563 D
plugins/wam-catalog/src/call_sites.rs consumed generated 57670 → 20226 1752293 → 919994 W
plugins/wam-catalog/src/generated.rs consumed generated 86175 → 86175 3596373 → 3596373 K
plugins/wam-catalog/src/lib.rs runtime/compatibility 756 → 756 27920 → 27927 K
plugins/wam-catalog/src/tests.rs test 539 → 539 19353 → 19353 K
plugins/wam-catalog/src/unlisted.rs runtime/compatibility 337 → 337 10719 → 10719 P
src/appstate_known_verbs.rs consumed generated 82 → 82 2914 → 2914 K
src/features/group_history.rs runtime/compatibility 1415 → 1415 54857 → 54843 K
CG/Cargo.toml tooling lock 29 → 29 1257 → 1257 G
CG/fixtures/accept_group_add.json fixture 168 → 168 4043 → 4043 K
CG/fixtures/capture-group-normalization.cjs fixture 18 → 43 1149 → 2597 K
CG/fixtures/contextual_iq.json fixture 3548 → 3548 114116 → 114116 K
CG/fixtures/group_actions_oracle.json fixture 2935 → 2935 74765 → 74765 K
CG/fixtures/group_create_oracle.json fixture 869 → 869 23464 → 23464 K
CG/fixtures/group_envelope.json fixture 555 → 555 13039 → 13039 K
CG/fixtures/group_envelope_oracle.json fixture 2842 → 2842 57226 → 57226 K
CG/fixtures/group_link.json fixture 126 → 126 2953 → 2953 K
CG/fixtures/group_link_evidence.json fixture 301 → 8 10605 → 637 L
CG/fixtures/group_link_oracle.json removed fixture/report 0 → 0 0 → 0 X
CG/fixtures/group_normalization_oracle.json fixture 5500 → 844 109923 → 22473 O
CG/fixtures/group_qualification_review.json removed fixture/report 326 → 0 14731 → 0 R
CG/fixtures/group_unlink.json fixture 304 → 304 7112 → 7112 K
CG/fixtures/group_unlink_evidence.json removed fixture/report 301 → 0 10605 → 0 U
CG/fixtures/group_unlink_oracle.json removed fixture/report 0 → 0 0 → 0 X
CG/fixtures/groups/versions/2.3000.1047483476/group_actions_oracle.json removed fixture/report 2931 → 0 74603 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_create_oracle.json removed fixture/report 537 → 0 14501 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_envelope.json removed fixture/report 555 → 0 13039 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_envelope_oracle.json removed fixture/report 982 → 0 27119 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_link.json removed fixture/report 119 → 0 2800 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_link_evidence.json removed fixture/report 28 → 0 1182 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_link_oracle.json removed fixture/report 534 → 0 10886 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_unlink.json removed fixture/report 283 → 0 6611 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_unlink_evidence.json removed fixture/report 29 → 0 1269 → 0 H
CG/fixtures/groups/versions/2.3000.1047483476/group_unlink_oracle.json removed fixture/report 199 → 0 3763 → 0 H
CG/fixtures/mex-retained-shapes.json fixture 154 → 154 3531 → 3531 P
CG/fixtures/snapshot-upgrade-1052559453.evidence.json removed fixture/report 377 → 0 23777 → 0 R
CG/fixtures/wam-retained-fields.json fixture 186 → 186 4157 → 4157 P
CG/fixtures/wam-retained-variants.json fixture 115 → 115 1976 → 1976 P
CG/iq-contextual.lock.json tooling lock 6 → 6 284 → 284 K
CG/src/emit/abprops.rs generator 424 → 424 14478 → 14478 G
CG/src/emit/community_create.rs generator 262 → 262 10551 → 10551 G
CG/src/emit/group_actions_conformance.rs generator 482 → 482 18539 → 18539 G
CG/src/emit/group_create_conformance.rs generator 497 → 497 18153 → 18153 G
CG/src/emit/group_envelope_conformance.rs generator 389 → 389 14557 → 14557 G
CG/src/emit/group_envelope_normalization.rs generator 345 → 345 15213 → 15213 G
CG/src/emit/group_link_normalization.rs generator 5 → 5 214 → 214 G
CG/src/emit/group_normalization.rs generator 543 → 652 20507 → 24217 G
CG/src/emit/iq_conformance.rs generator 231 → 231 8496 → 8496 G
CG/src/emit/iq_contextual.rs generator 151 → 151 5334 → 5334 G
CG/src/emit/iq_pilots.rs generator 559 → 559 21415 → 21415 G
CG/src/emit/iq_targets.rs generator 296 → 296 10616 → 10616 G
CG/src/emit/mex.rs generator 672 → 672 25528 → 25528 G
CG/src/emit/wam.rs generator 790 → 786 31753 → 31993 G
CG/src/ir.rs generator 548 → 548 16873 → 16873 G
CG/src/main.rs generator 783 → 783 29458 → 29458 G
CG/src/source.rs generator 389 → 389 14031 → 14031 G
CG/tests/committed_artifacts.rs test 138 → 138 5211 → 5211 K
CG/tests/fixtures/community_create.json fixture 571 → 571 17137 → 17137 K
CG/whatspec.lock.json tooling lock 22 → 22 1666 → 1666 K
wacore/appstate/src/schemas.rs consumed generated 1771 → 1771 55014 → 55014 K
wacore/src/companion_reg.rs runtime/compatibility 547 → 547 19285 → 19285 K
wacore/src/history_sync.rs runtime/compatibility 5377 → 5377 222650 → 222650 K
wacore/src/iq/abprops.rs consumed generated 23596 → 23596 920272 → 920272 K
wacore/src/iq/community_create.rs consumed generated 39 → 39 1443 → 1443 K
wacore/src/iq/contextual.rs consumed generated 3035 → 3035 169773 → 169773 K
wacore/src/iq/join_shapes.rs consumed generated 40 → 40 1816 → 1816 K
wacore/src/iq/mex_operations.rs consumed generated 14285 → 14285 561991 → 561991 K
wacore/src/iq/mex_operations_unlisted.rs runtime/compatibility 546 → 546 21047 → 21047 P
wacore/src/iq/pilot_conformance.rs test 95 → 95 3929 → 3929 K
wacore/src/iq/pilots.rs consumed generated 81 → 81 2228 → 2228 K
wacore/src/iq/props.rs runtime/compatibility 1569 → 1569 54287 → 54287 P
wacore/src/iq/targets.rs consumed generated 54 → 54 3013 → 3013 K
wacore/src/proto_helpers.rs runtime/compatibility 2876 → 2876 111168 → 111168 K
wacore/src/stanza/groups.rs runtime/compatibility 2143 → 2143 83702 → 83702 K
GR/actions_conformance.rs test 2532 → 2532 102884 → 102884 K
GR/actions_normalized.rs runtime/compatibility 1080 → 1080 40752 → 40822 K
GR/actions_oracle_projection.rs test 259 → 259 9628 → 9628 K
GR/create_conformance.rs test 2847 → 2847 95702 → 95702 K
GR/create_normalized.rs runtime/compatibility 648 → 648 25000 → 25063 K
GR/envelope_conformance.rs test 2077 → 2077 73421 → 73421 K
GR/envelope_generated.rs consumed generated 234 → 234 8843 → 8843 K
GR/link_generated.rs consumed generated 54 → 54 3038 → 3038 K
GR/link_normalized.rs runtime/compatibility 149 → 149 5561 → 5561 K
GR/normalization_conformance.rs test 4480 → 752 168549 → 21732 T
GR/normalization_warning.rs runtime/compatibility 164 → 164 5810 → 5810 K
GR/normalized.rs runtime/compatibility 607 → 607 22587 → 22587 K
GR/normalized_notification.rs runtime/compatibility 185 → 185 7461 → 7461 K
GR/unlink_generated.rs consumed generated 164 → 164 7756 → 7756 K
wacore/src/stanza/wire_tags.rs consumed generated 111 → 111 2753 → 2753 K
wacore/src/types/wire_enums.rs consumed generated 216 → 216 5941 → 5941 K
wacore/src/version/generated.rs consumed generated 12 → 12 550 → 550 K
wacore/tests/abprops_retained.rs test 111 → 111 5698 → 5698 K
wacore/tests/context_info.rs test 388 → 388 13677 → 13677 K
wacore/tests/mex_retained.rs test 80 → 80 2909 → 2909 K
wacore/tests/props_stream_memory.rs test 296 → 296 12563 → 12563 K
waproto/build.rs generator 503 → 503 20846 → 20846 K
waproto/build_support/emission.rs generator 728 → 728 30833 → 30833 K
waproto/build_support/wallpaper.rs generator 223 → 223 8305 → 8305 K
waproto/src/whatsapp.desc consumed generated 62577 → 62577 686961 → 686961 K
waproto/src/whatsapp.desc.sha256 consumed generated 2 → 2 141 → 141 K
waproto/src/whatsapp.proto consumed generated 8183 → 8183 242559 → 242559 K
waproto/tests/generated_api.rs test 345 → 345 13020 → 13020 K
waproto/tests/retained_schema.rs test 106 → 106 4501 → 4501 K

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[High impact] No blocking code issue was found in this re-review; the PR’s stated validation and performance gates remain separate merge requirements.

Summary

Updates the WhatsApp snapshot and reduces repeated generated code and fixtures.

  • WhatsApp protocol definitions and generated Rust types match the newer snapshot.
  • Group notifications preserve action order and report unknown LINK and UNLINK types.
  • Upgrade fixtures and generated tests reuse shared observations instead of repeated snapshots.
  • Older public telemetry, request, and wallpaper contracts remain usable alongside the newer capture.

Reviews (13) · Last reviewed commit: "[autofix.ci] apply automated fixes" · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 5 unresolved issues from previous reviews.

Re-trigger cubic

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

📦 Binary size report

Metric main PR Δ
bin size (stripped) 11.37 MiB 11.43 MiB +60.25 KiB (+0.52%) 🔺
bin .text 9.18 MiB 9.24 MiB +59.31 KiB (+0.63%) 🚨
bin allocated (text+data+bss) 11.37 MiB 11.43 MiB +59.94 KiB (+0.51%) 🔺
deps crates (Cargo.lock) 573 573 0

Heavy diagnostics were omitted from this gate-only measurement. The size gate uses the linked binary measurements above.

🚨 Per-PR size budget exceeded (Δ stripped ≤ 64.00 KiB, Δ .text ≤ 32.00 KiB):

  • bin .text: +59.31 KiB (+0.63%) exceeds the 32.00 KiB per-PR budget

The size-increase-ok label is set, so the gate is not enforced for this PR.

Baseline: 0d1373a8f · Head: c6b27efc1 · Graphs

@codspeed

codspeed Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 78.25%

3 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 136 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 4 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 4 improved benchmarks
✅ 920 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Walltime four_external_blobs[65536] 469.9 µs 207.4 µs ×2.3
⚡ Walltime eight_clients[65536] 3.1 ms 1.8 ms +70.6%
⚡ Walltime four_external_blobs[1048576] 5.4 ms 3.2 ms +66.57%
⚡ Walltime eight_clients[1048576] 42.9 ms 27.3 ms +56.82%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing feat/whatspec-23000-1052559453 (c6b27ef) with main (0d1373a)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@jlucaso1 jlucaso1 changed the title chore(codegen): prepare WhatsApp 2.3000.1052559453 integration feat(protocol): update WhatsApp to 2.3000.1052559453 Nov 1, 2026
Comment thread wacore/src/iq/mex_operations.rs Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 83 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 10 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 5 unresolved issues from previous reviews.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Regenerates WhatsApp protocol artifacts from a new whatspec pin and changes group-history, CREATE, LINK/UNLINK, and IQ error handling; unresolved dismissed findings on fixture requalification and evidence reproducibility leave decisive claims unverified.

Re-trigger cubic

@jlucaso1 jlucaso1 added the size-increase-ok Accepted binary-size increase: downgrades the per-PR size gate to a warning label Nov 1, 2026 — with ChatGPT Codex Connector

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread wacore/src/iq/abprops.rs Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread wacore/tests/abprops_retained.rs Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Regenerates WhatsApp protocol artifacts from an open whatspec PR pin and changes group-history, IQ error, and group-normalization behavior; decisive factors are the unmerged pin and unresolved qualification evidence.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 16 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Regenerates WhatsApp 2.3000.1052559453 protocol artifacts from the merged whatspec pin, but keeps group-history window and IQ error-contract behavior changes and unresolved qualification evidence.

Re-trigger cubic

@jlucaso1 jlucaso1 changed the title feat(protocol): update WhatsApp to 2.3000.1052559453 feat(protocol): update WhatsApp snapshot and compact codegen Nov 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 25 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Regenerates WhatsApp 2.3000.1052559453 protocol artifacts from a pinned whatspec rev with broad tests; group-history, group-notification, and IQ error-contract behavior changes and unresolved performance qualification remain for human sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Regenerates WhatsApp protocol artifacts from a new pinned whatspec rev; group-history retrieval, group-notification/error contracts and runtime performance change, and the delta only canonicalizes the oracle, so human sign-off is required.

Re-trigger cubic

@jlucaso1

jlucaso1 commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T13:42:36.527805Z c6b27ef Draft marked ready
🔒 Security Review ✅ Completed 2026-11-01T13:44:25.329059Z c6b27ef Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: c6b27efc1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jlucaso1
jlucaso1 marked this pull request as ready for review November 1, 2026 13:40
@jlucaso1
jlucaso1 merged commit aab35eb into main Nov 1, 2026
66 of 67 checks passed
@jlucaso1
jlucaso1 deleted the feat/whatspec-23000-1052559453 branch November 1, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-increase-ok Accepted binary-size increase: downgrades the per-PR size gate to a warning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant