You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thanks for the great library! We'd love to try it out in production. I'd also be happy to contribute to its development and share our experience along the way :)
What and why:
Added zizmor to improve the security of GitHub Actions workflows by detecting common security issues and potentially dangerous configurations
Added a cooldown configuration to reduce update noise and provide a safety window for potentially compromised releases to be discovered before adoption
Thanks, and good to hear you're looking at it for production. If anything gets in your way there, please open an issue or ping me.
The cooldown is a good idea and I'd like to merge it :)
I'd leave the zizmor part out of this PR, for two reasons:
Nothing runs zizmor yet. No workflow calls it, so the config file on its own doesn't check anything.
"*": ref-pin loosens the default. With no * rule, zizmor requires a hash pin for every action, and every action here is already pinned to a SHA. This setting would let a tag pin through, including on pypa/gh-action-pypi-publish in the release job.
I'd also prefer to keep secrets-outside-env on and act on what it flags than switch it off.
Could you drop .github/zizmor.yml and keep this PR to the cooldown?
*I'll add a zizmor job separately. CI is waiting on approval, and I'll start it once you've pushed.
Thanks, and good to hear you're looking at it for production. If anything gets in your way there, please open an issue or ping me.
The cooldown is a good idea and I'd like to merge it :)
I'd leave the zizmor part out of this PR, for two reasons:
1. Nothing runs zizmor yet. No workflow calls it, so the config file on its own doesn't check anything.
2. `"*": ref-pin` loosens the default. With no `*` rule, zizmor requires a hash pin for every action, and every action here is already pinned to a SHA. This setting would let a tag pin through, including on `pypa/gh-action-pypi-publish` in the release job.
I'd also prefer to keep secrets-outside-env on and act on what it flags than switch it off.
Could you drop .github/zizmor.yml and keep this PR to the cooldown? *I'll add a zizmor job separately. CI is waiting on approval, and I'll start it once you've pushed.
@kondratevdev I opened #48 for the zizmor job, in case you would like to take it. No pressure either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the great library! We'd love to try it out in production. I'd also be happy to contribute to its development and share our experience along the way :)
Added
zizmorto improve the security of GitHub Actions workflows by detecting common security issues and potentially dangerous configurationsAdded a
cooldownconfiguration to reduce update noise and provide a safety window for potentially compromised releases to be discovered before adoptionNot needed
Not user-visible