Skip to content

Update dependabot cooldown - #44

Merged
PhiLily merged 2 commits into
oxpull:mainfrom
kondratevdev:zizmor
Sep 15, 2026
Merged

PhiLily merged 2 commits into
oxpull:mainfrom
kondratevdev:zizmor

Conversation

@kondratevdev

@kondratevdev kondratevdev commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Hi! Thanks for the great library! We'd love to try it out in production. I'd also be happy to contribute to its development and share our experience along the way :)

  • What and why:
    Added zizmor to improve the security of GitHub Actions workflows by detecting common security issues and potentially dangerous configurations
    Added a cooldown configuration to reduce update noise and provide a safety window for potentially compromised releases to be discovered before adoption
  • Tests:
    Not needed
  • Changelog:
    Not user-visible

@kondratevdev kondratevdev changed the title Add zizmor, update dependabot cooldown Add zizmor, update dependabot cooldown Sep 14, 2026
@PhiLily

PhiLily commented Sep 14, 2026

Copy link
Copy Markdown
Member

Thanks, and good to hear you're looking at it for production.
If anything gets in your way there, please open an issue or ping me.

The cooldown is a good idea and I'd like to merge it :)

I'd leave the zizmor part out of this PR, for two reasons:

  1. Nothing runs zizmor yet. No workflow calls it, so the config file on its own doesn't check anything.
  2. "*": ref-pin loosens the default. With no * rule, zizmor requires a hash pin for every action, and every action here is already pinned to a SHA. This setting would let a tag pin through, including on pypa/gh-action-pypi-publish in the release job.

I'd also prefer to keep secrets-outside-env on and act on what it flags than switch it off.

Could you drop .github/zizmor.yml and keep this PR to the cooldown?
*I'll add a zizmor job separately. CI is waiting on approval, and I'll start it once you've pushed.

Thanks! @kondratevdev 👑

@kondratevdev

Copy link
Copy Markdown
Contributor Author

Thanks, and good to hear you're looking at it for production. If anything gets in your way there, please open an issue or ping me.

The cooldown is a good idea and I'd like to merge it :)

I'd leave the zizmor part out of this PR, for two reasons:

1. Nothing runs zizmor yet. No workflow calls it, so the config file on its own doesn't check anything.

2. `"*": ref-pin` loosens the default. With no `*` rule, zizmor requires a hash pin for every action, and every action here is already pinned to a SHA. This setting would let a tag pin through, including on `pypa/gh-action-pypi-publish` in the release job.

I'd also prefer to keep secrets-outside-env on and act on what it flags than switch it off.

Could you drop .github/zizmor.yml and keep this PR to the cooldown? *I'll add a zizmor job separately. CI is waiting on approval, and I'll start it once you've pushed.

Thanks! @kondratevdev 👑

Sure! Thank you for feedback!

@kondratevdev kondratevdev changed the title Add zizmor, update dependabot cooldown Update dependabot cooldown Sep 15, 2026
@PhiLily
PhiLily merged commit eda54a9 into oxpull:main Sep 15, 2026
30 checks passed
@PhiLily

PhiLily commented Sep 15, 2026

Copy link
Copy Markdown
Member

@kondratevdev I opened #48 for the zizmor job, in case you would like to take it. No pressure either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants