Draft
Add referenceHumidity and observedHumidity parameters to altitudeFromPressureDifference#44
Conversation
…PressureDifference Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
…non-null assertions Co-authored-by: oyve <16225018+oyve@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize altitude calculation using humidity input
Add referenceHumidity and observedHumidity parameters to altitudeFromPressureDifference
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances
altitudeFromPressureDifferenceto accept separate humidity values at reference and observed altitudes. Since humidity varies with altitude, using distinct values for each level and averaging their virtual temperatures provides more accurate altitude calculations than a single uniform humidity.Type of Change
Related Issue
Addresses the question: "Could altitudeFromPressureDifference be improved even more having a referenceHumidity and a observedHumidity?"
Changes Made
referenceHumidityandobservedHumidityoptional parameters toaltitudeFromPressureDifferencerelativeHumidityparameter still works unchangedFormula Details (if applicable)
Formula Name
Hypsometric equation with humidity-varying virtual temperature
Scientific Source
Input Parameters
referencePressure: Pressure at reference altitude (Pa)observedPressure: Pressure at observed altitude (Pa)referenceAltitude: Known altitude (m), default 0temperature: Average temperature (K), default 288.15relativeHumidity: Single humidity for both levels (%), optionalreferenceHumidity: Humidity at reference altitude (%), optionalobservedHumidity: Humidity at observed altitude (%), optionalOutput
Validation
Testing
Test Coverage
npm test)npm run build)Test Results
Manual Testing
Added 8 new tests covering: separate humidity values, equal humidity matching single-humidity behavior, fallback to dry air when only one humidity provided, priority over single humidity, and extreme humidity differences.
Documentation
Checklist
Breaking Changes
Performance Impact
Dependencies
Reviewer Notes
src/formulas/altitude.ts,tests/formulas/altitude.test.tsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.