Repository navigation
feat(core): topical dedup context — build_dedup_context + WASM/PyO3 bindings (PRD-04 DEP-3, Part A) - #669
Open
p-diogo wants to merge 3 commits into
Open
feat(core): topical dedup context — build_dedup_context + WASM/PyO3 bindings (PRD-04 DEP-3, Part A)#669p-diogo wants to merge 3 commits into
p-diogo wants to merge 3 commits into
Conversation
…ure (PRD-04 DEP-3) Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Owner
Author
Whole-PR review (Sonnet): verdict MERGE-WITH-FOLLOW-UPS (nothing blocking)I read the code and the CI results. Rust Core, Python, Cross-Language Parity and Phrase Safety all passed; the TS, MCP, plugin and web jobs were legitimately path-filtered.
Follow-ups (tracked in the internal repo):
|
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PRD-04 DEP-3 (F2), Part A: core only. This adds the new module
rust/totalreclaw-core/src/dedup_context.rs.build_dedup_context(topical, pinned, recent, cap) -> Stringrenders the "Existing memories" block the extraction prompt receives:[ID: <fact id>] <text>line per memory, pinned first, then topical, then recent;caplines (default 30);""when nothing survives.Bindings: WASM
buildDedupContext, PyO3build_dedup_context(JSON in, String out).Parity
tests/parity/fixtures/dedup-context-v1.jsonholds 14 cases.generate-dedup-context-v1.pywrites it from an independent Python reference implementation. Three suites check it:cargo test dedup_context(15 tests)tests/parity/dedup-context-parity.test.ts(new step in CI jobcross-language-parity)python/tests/test_dedup_context_parity.py(CI jobpython-tests)Spec deviation
Enclave spec §4.6 sketches
Vec<Claim>. The v0Claimhas no id, and each line must carry the on-chain fact id that the LLM echoes back asexistingFactId. The element type is thereforeDedupContextItem { id, text }.Not in this PR
agent/lifecycle.py) is Part B. It is dispatched aftertotalreclaw-core2.7.0 is published.🤖 Generated with Claude Code