Get rid of a couple warning messages.#341
Get rid of a couple warning messages.#341lwandrebeck wants to merge 4 commits intop-e-w:masterfrom lwandrebeck:warnings
Conversation
|
Thank you for your effort here. I have to admit I'm a bit undecided as to whether I actually want to merge this. As it stands, this adds 15 lines of code with no benefit at all (as indicated in the comments, this is not "real" error handling) besides silencing the warnings, especially in the case of the regex which is almost guaranteed not to fail in practice. I merged such a PR before and have regretted it many times since as the I'm not referring to the P.S.: For some reason your commit messages are doubled. Don't know what's going on here. |
|
To be honest, I have often considered removing most existing |
....