This repository was archived by the owner on Nov 11, 2018. It is now read-only.
IND/RI/NEL control sequence implementations#350
Open
cepko33 wants to merge 7 commits intop-e-w:masterfrom
Open
IND/RI/NEL control sequence implementations#350cepko33 wants to merge 7 commits intop-e-w:masterfrom
cepko33 wants to merge 7 commits intop-e-w:masterfrom
Conversation
src/TerminalOutput.vala
Outdated
Owner
There was a problem hiding this comment.
This should probably be commented again as it slows some large terminal programs to a crawl.
Author
|
For the changes to the VERTICAL_TAB and REVERSE_INDEX switches, my test case was the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first in what will be a series of control sequence implementations, starting off with INDEX, REVERSE_INDEX, and NEXT_LINE. Currently, the steps used for each are:
In addition, the VERTICAL_TAB case was modified to allocate new line views and then scroll to the bottom of the terminal view
My main use case for this feature was
man, so once I could successfully scroll up and down, I knew that progress had been made.Some potential future control sequences have been added to the
enumalong with markings specifying which sequences have been implemented or not.Bugs Introduced:
While running the
vttestdisplay test (option 1) the scroll_offset seems to become negative to around -37 or so, and I'm interested in the functionerase_range_screenwhich seems to be accessing terminal space with an "absolute position"