This repository was archived by the owner on Nov 11, 2018. It is now read-only.
[DO NOT PULL] Issue #7 Selection and Copy#389
Open
Eugene-msc wants to merge 1 commit intop-e-w:masterfrom
Open
[DO NOT PULL] Issue #7 Selection and Copy#389Eugene-msc wants to merge 1 commit intop-e-w:masterfrom
Eugene-msc wants to merge 1 commit intop-e-w:masterfrom
Conversation
Normal, Word and Line selections. Copy of selected text.
Owner
There was a problem hiding this comment.
Why do these lines have to be commented? The "Shift+Insert" shortcut works on my system even with these lines enabled – it's the "Ctrl+Shift+V" shortcut I can't get to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second pull request on the same subject because I screwed up with my git branch and did not know how to undo it. I closed the previous one.
This is my implementation of selection and copy.
I made this PR because I am not sure that the way I implemented it is a good one.
It is not yet done and there probably are some bugs, the code is not up to standard and I have concerns about performance.
I was doing it mostly for fun, so if it will be decided to proceed with this implementation I will be working on solving the problems mentioned above.
What works:
Normal selection
Word selection (double click)
Line selection (triple click)
Copy to clipboard
What needs to be done:
Stylable selection
Characters that are considered part of the word should be changeable via settings window (?)
Column selection (? @p-e-w wrote that we can do without it for the time. The bad thing about this implementation is that we will probably need to do some major changes to line creation and wrap system to make column selection work )
PS It will not be too hard to implement sublimetext-like multiple selections. Are there plans for this?