fix(setup): probe the distro's cpupower package name so Debian installs don't fail - #337
Merged
Conversation
…ls don't fail (#327) The apt dependency list named linux-tools-common unconditionally, but that package is Ubuntu-only — Debian ships cpupower as linux-cpupower — and apt's install transaction is all-or-nothing, so the one unknown name failed the ENTIRE dependency install: git, build-essential and cmake never arrived either. Probe with apt-cache show (the same guard the kernel-versioned linux-tools-$(uname -r) package already had) and add whichever name the distro actually ships; when neither exists, warn and carry on — cpupower is a tuning aid, never worth losing the compiler toolchain over. Closes #327 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
VijitSingh97
added a commit
that referenced
this pull request
Aug 2, 2026
…ls don't fail (#327) (#337) The apt dependency list named linux-tools-common unconditionally, but that package is Ubuntu-only — Debian ships cpupower as linux-cpupower — and apt's install transaction is all-or-nothing, so the one unknown name failed the ENTIRE dependency install: git, build-essential and cmake never arrived either. Probe with apt-cache show (the same guard the kernel-versioned linux-tools-$(uname -r) package already had) and add whichever name the distro actually ships; when neither exists, warn and carry on — cpupower is a tuning aid, never worth losing the compiler toolchain over. Closes #327 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327
Problem
_detect_pkg_manager's apt branch listedlinux-tools-commonunconditionally. That package is Ubuntu-only — Debian ships cpupower aslinux-cpupower— and apt's install transaction is all-or-nothing, so the one unknown name failed the ENTIRE dependency install on Debian: git, build-essential and cmake never arrived either (E: Unable to locate package linux-tools-common). Found on Debian trixie during the pithead#797 R0 recon, but it breaks plain DIY installs on Debian too.Fix
Probe with
apt-cache show— the same guard the kernel-versionedlinux-tools-$(uname -r)package two lines down already uses — and add only the name this distro actually ships:linux-tools-common(Ubuntu) orlinux-cpupower(Debian). When neither exists, warn and carry on: cpupower is a tuning aid, never worth losing the compiler toolchain over.Tests
linux-tools-commonpicked,linux-cpupowerstays out — asserted on the existing setup: dependency install fails on a fresh boot when apt/dpkg is locked by unattended-upgrades #74 scenario.linux-cpupowerexists):linux-cpupowerpicked,linux-tools-commonstays out.build-essentialet al.) still reaches apt.bash tests/run.sh: 1612 passed, 0 failed.shellcheck -S warning rigforge.sh: clean.🤖 Generated with Claude Code