style: squeeze text and center it on page#17
Open
AnInternetTroll wants to merge 1 commit intop2sr:mainfrom
Open
style: squeeze text and center it on page#17AnInternetTroll wants to merge 1 commit intop2sr:mainfrom
AnInternetTroll wants to merge 1 commit intop2sr:mainfrom
Conversation
Reasoning --------- The idea behind limiting the text's width is to make it easier for users on large screens to read it. Many professionals[1][2][3] recommend somewhere in the 60-80 words per line, as such this commit adds a max width to text of 600px, which should be roughly 60-70 words per line. Technical implementation ------------------------ The technical implementation wraps every "text" content in a class, and limits the width of that class's children. This is done as to not limit the content of the whole page, and in particular the categories cards. In addition the page's content is centered for aesthetic reasons. [1]: https://www.w3.org/WAI/WCAG21/Understanding/visual-presentation.html#:~:text=For%20people%20with%20some,80%20characters%20or%20glyphs [2]: http://web-accessibility.carnegiemuseums.org/design/font/#:~:text=Line%20length,longer%20length [3]: https://www.uutilsynet.no/veiledning/tekst-og-struktur/226#:~:text=For%20best%20mulig%20lesbarhet,inkludert%20mellomrom
AnInternetTroll
force-pushed
the
user/luca/center
branch
from
3d32259 to
1d66162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
The idea behind limiting the text's width is to make it easier for users
on large screens to read it.
Many professionals1 2 3 recommend somewhere in the 60-80 words per
line, as such this commit adds a max width to text of 600px, which
should be roughly 60-70 words per line.
Technical implementation
The technical implementation wraps every "text" content in a class, and
limits the width of that class's children. This is done as to not limit
the content of the whole page, and in particular the categories cards.
In addition the page's content is centered for aesthetic reasons.