support time units of either hours or days#9
Merged
Merged
Conversation
QSparks
approved these changes
Feb 27, 2026
Contributor
QSparks
left a comment
QSparks
left a comment
There was a problem hiding this comment.
Looks great! I downloaded a few timeseries from the demo and everything looks in order.
Would we want to add a case for files that might be missing the %H:%M:%S component in the days since … time string?
As an aside, netCDF4.num2date is fairly robust for time conversion if we ever need it down the road, though it’s probably unnecessary here since we’re consistently using Gregorian calendars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for netCDF files whose time variables are measured in days, matching new indexing standards.
Demo.
Resolves #8