I32 prelaunch#33
Open
QSparks wants to merge 13 commits into
Open
Conversation
This reverts commit 6a74271.
Nospamas
approved these changes
May 14, 2026
Nospamas
left a comment
Nospamas
left a comment
There was a problem hiding this comment.
Couple of short notes. Otherwise looks good.
| def _header_title_pane(): | ||
| logo_html = "" | ||
| if LOGO_PATH.exists(): | ||
| encoded = base64.b64encode(LOGO_PATH.read_bytes()).decode("ascii") |
There was a problem hiding this comment.
This can probably be converted once and cached, unless panel handles that for you anyway
| if not services_available(): | ||
| update_launch_state() | ||
| user_warn( | ||
| "Submission is blocked because one or more required services are down.", |
There was a problem hiding this comment.
phrasing wise, it might be better to say "unavailable" instead of "down"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #32
Added:
Removed:
Fixed: