Maintenance updates#76
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rod-glover
left a comment
rod-glover
left a comment
There was a problem hiding this comment.
LGTM, with the caveat that the hardcoded server addresses might better be parametrized and provided externally.
| strategy: | ||
| matrix: | ||
| python-version: [3.7, 3.8] | ||
| python-version: ["3.11", "3.12"] |
There was a problem hiding this comment.
In another bird, the matrix was just 3.11. What's the criterion for Python versions to test with in these repos?
There was a problem hiding this comment.
3.12 may be required in this particular repository to support running on the newest geospatial-python docker, which supports only python 3.12 right now.
| "output_type": "stream", | ||
| "text": [ | ||
| "Using sandpiper on https://docker-dev03.pcic.uvic.ca/twitcher/ows/proxy/sandpiper/wps\n" | ||
| "Using sandpiper on https://marble-dev01.pcic.uvic.ca/twitcher/ows/proxy/sandpiper/wps\n" |
There was a problem hiding this comment.
There are a lot of hardcoded server specs in this bird. I wonder if they can be factored out into ENV vars or the like, so that they are shared and easily updated.
| "\u001b[0;31mFile:\u001b[0m ~/code/birds/sandpiper/</tmp/sandpiper-venv/lib/python3.8/site-packages/birdy/client/base.py-2>\n", | ||
| "\u001b[0;31mType:\u001b[0m method\n" | ||
| "\u001b[31mFile:\u001b[39m ~/python-sprint/py-repos/sandpiper/</home/quintins/.cache/pypoetry/virtualenvs/sandpiper-Bm4285Lb-py3.12/lib/python3.12/site-packages/birdy/client/base.py-2>\n", | ||
| "\u001b[31mType:\u001b[39m method" |
There was a problem hiding this comment.
This looks a bit fragile to me. Is there a better place to store this cache?
4 participants
Pending: