Skip to content

Maintenance updates#62

Merged
QSparks merged 11 commits into
masterfrom
py-sprint-25q1
Jun 16, 2025
Merged

Maintenance updates#62
QSparks merged 11 commits into
masterfrom
py-sprint-25q1

Conversation

@QSparks
Copy link
Copy Markdown
Contributor

@QSparks QSparks commented Jun 13, 2025

  • PEP 621-conformant pyproject.toml
  • Poetry >2.0
  • Replace pkg_resources with importlib.resources
  • Monkey patch for errors due to a non-strict package version in the netCDF4 package being enforced by our “birdy” dependency

@QSparks QSparks self-assigned this Jun 13, 2025
Copy link
Copy Markdown

@Nospamas Nospamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note on lockfile in action, otherwise looks good.

Comment thread .github/workflows/python-ci.yml Outdated

- name: Re-lock dependencies
run: |
poetry lock
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this defeat the point of a lockfile?

@QSparks QSparks requested a review from Nospamas June 16, 2025 18:33
Copy link
Copy Markdown

@Nospamas Nospamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@QSparks QSparks merged commit 9475c54 into master Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants