Wx files memo locations#37
Merged
Merged
Conversation
corviday
approved these changes
Aug 6, 2025
Contributor
corviday
left a comment
corviday
left a comment
There was a problem hiding this comment.
Looks straightforward, nice to have the documentation. I'm fine with deploying this to prod, since the prod backend is already broken and we have nothing to lose. :)
rod-glover
approved these changes
Aug 6, 2025
Collaborator
rod-glover
left a comment
rod-glover
left a comment
There was a problem hiding this comment.
LGTM, clean and simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to slowdowns on the locations call, we've opted to memoise the call as the data rarely changes. Issue #36 concerns more long term solutions to this problem, but this will at least make the app fast after initial population.