Skip to content

build(windows): build usearch without numkong in atlas-retrieval too - #383

Closed
ik0zy wants to merge 1 commit into
pacifio:0.4.0from
ik0zy:ik0zy/fix-windows-atlas-retrieval-usearch
Closed

ik0zy wants to merge 1 commit into
pacifio:0.4.0from
ik0zy:ik0zy/fix-windows-atlas-retrieval-usearch

Conversation

@ik0zy

@ik0zy ik0zy commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

What?

Same split #367 applied to atlas-memory, now for atlas-retrieval: usearch with default-features = false, plus its numkong feature only under cfg(not(windows)).

Why?

#367 got the Windows app build green by removing numkong from the build on Windows. Then #382 merged and wired a new path into the app — atlas-codeindex → atlas-retrieval → usearch with default features — which reintroduced the exact same numkong MSVC ARM64 failure (<immintrin.h> C1189) in the app (src-tauri, Windows) job on every PR. #366 and #375 currently fail only on that job.

No new dependencies, no telemetry changes.

How?

crates/atlas-retrieval/Cargo.toml:

  • usearch = { version = "2.25.3", default-features = false }
  • [target.'cfg(not(windows))'.dependencies] usearch = { version = "2.25.3", features = ["numkong"] }

Verified without compiling:

  • cargo metadata --locked passes, Cargo.lock unchanged.
  • cargo tree --locked --workspace --target aarch64-pc-windows-msvc -e features -i numkong: nothing in the whole workspace.
  • aarch64-apple-darwin / x86_64-unknown-linux-gnu: numkong still enabled, so macOS and Linux are unchanged.

Same trade-off as #367: vector search on Windows runs without numkong's SIMD kernels. Windows isn't a supported platform yet.

Follow-up to #367. Once this merges into 0.4.0, #366 and #375 need a rebase (or CI re-run) to pick it up.

Checklist

  • Targets the current version branch (0.4.0)
  • No behaviour change outside Windows; dependency features only
  • app (src-tauri, Windows) passes in CI

Follow-up to pacifio#367: pacifio#382 added atlas-codeindex -> atlas-retrieval ->
usearch (default features) into the app's Windows build, reintroducing
the numkong MSVC ARM64 failure pacifio#367 removed via atlas-memory.
Apply the same split here: default-features = false plus numkong only
under cfg(not(windows)). Cargo.lock unchanged.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 574e89d2-9fd1-48c6-b75d-1777a3e6f26d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ik0zy

ik0zy commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by 20db9b1 on 0.4.1 ("memory: M0 – atlas-retrieval builds usearch without numkong on Windows"), which makes the identical change. Closing.

@ik0zy ik0zy closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant