Repository navigation
Conversation
Follow-up to pacifio#367: pacifio#382 added atlas-codeindex -> atlas-retrieval -> usearch (default features) into the app's Windows build, reintroducing the numkong MSVC ARM64 failure pacifio#367 removed via atlas-memory. Apply the same split here: default-features = false plus numkong only under cfg(not(windows)). Cargo.lock unchanged.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Author
|
Superseded by 20db9b1 on 0.4.1 ("memory: M0 – atlas-retrieval builds usearch without numkong on Windows"), which makes the identical change. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Same split #367 applied to
atlas-memory, now foratlas-retrieval:usearchwithdefault-features = false, plus itsnumkongfeature only undercfg(not(windows)).Why?
#367 got the Windows app build green by removing numkong from the build on Windows. Then #382 merged and wired a new path into the app —
atlas-codeindex→atlas-retrieval→usearchwith default features — which reintroduced the exact same numkong MSVC ARM64 failure (<immintrin.h>C1189) in theapp (src-tauri, Windows)job on every PR. #366 and #375 currently fail only on that job.No new dependencies, no telemetry changes.
How?
crates/atlas-retrieval/Cargo.toml:usearch = { version = "2.25.3", default-features = false }[target.'cfg(not(windows))'.dependencies] usearch = { version = "2.25.3", features = ["numkong"] }Verified without compiling:
cargo metadata --lockedpasses,Cargo.lockunchanged.cargo tree --locked --workspace --target aarch64-pc-windows-msvc -e features -i numkong: nothing in the whole workspace.aarch64-apple-darwin/x86_64-unknown-linux-gnu: numkong still enabled, so macOS and Linux are unchanged.Same trade-off as #367: vector search on Windows runs without numkong's SIMD kernels. Windows isn't a supported platform yet.
Follow-up to #367. Once this merges into
0.4.0, #366 and #375 need a rebase (or CI re-run) to pick it up.Checklist
0.4.0)app (src-tauri, Windows)passes in CI