Repository navigation
test(scripts): run the target-gc suite on Windows - #385
Merged
emirhanyesilgul merged 1 commit intoOct 7, 2026
Merged
emirhanyesilgul merged 1 commit into
emirhanyesilgul merged 1 commit into
Conversation
The suite set PATH to `<stubs>:/usr/bin:/bin`. On Windows Node can't resolve that, so every case failed with `spawnSync bash ENOENT`, and so did `test:contracts` in the pre-commit hook on any Windows checkout. `ci:local` runs target-gc.sh on Windows too, through Git Bash. So the suite now puts Git Bash's usr/bin (bash plus coreutils, found from PATH or next to Git's cmd/) after the stubs, joined with the platform's delimiter. It drops Windows' `Path` spelling so the child sees one PATH. Linux and macOS get the same `/usr/bin:/bin` as before.
3 tasks done
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
tests/target-gc.test.tsruns on Windows, through Git Bash.Why?
The suite set PATH to
<stubs>:/usr/bin:/bin. On Windows Node can't resolve that, so every case failed withspawnSync bash ENOENT. Since #362, the pre-commit hook'stest:contractsfails on every Windows checkout, so no commit gets through the hooks there.How?
ci:localrunstarget-gc.shon Windows through Git Bash too, so the suite should run there rather than be skipped.usr/bin(bash and the coreutils the script calls), joined withpath.delimiter.usr/binis found on PATH, or next to Git'scmd/when the shell isn't Git Bash (PowerShell's PATH usually has onlyGit\cmd). System32'sbash.exeis skipped: that's WSL's.Pathspelling is dropped, so the child sees one PATH./usr/bin:/binas before.Verified on Windows 11: 6/6 from both Git Bash and PowerShell,
test:contracts268/268, and the fullbun run testin the pre-push hook.Checklist
0.4.1)