Repository navigation
release-linux: pin runner to ubuntu-22.04 and guard the glibc baseline - #388
Open
faisalahmedsifat wants to merge 1 commit into
Open
faisalahmedsifat wants to merge 1 commit into
faisalahmedsifat wants to merge 1 commit into
Conversation
Built on ubuntu-latest (24.04, glibc 2.39), the release binary refuses to start on 22.04-based distros (Pop!_OS 22.04, Mint 21): the loader fails with GLIBC_2.38/2.39 not found even though the package installs fine. glibc is backward-compatible only, so build on the oldest supported Ubuntu (22.04, glibc 2.35) to stay runnable everywhere newer. Jammy's default gcc-11 also cannot compile numkong's AVX512-FP16 kernels, so point CC/CXX at gcc-12. A post-build objdump check fails the job if the binary ever requires newer than GLIBC_2.35 again.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Built on
ubuntu-latest(24.04, glibc 2.39), the release binary refuses to start on 22.04-based distros (Pop!_OS 22.04, Mint 21): the loader fails withGLIBC_2.38/GLIBC_2.39not found even though the package installs fine. glibc is backward-compatible only, so build on the oldest supported Ubuntu (22.04, glibc 2.35) to stay runnable everywhere newer.Jammy's default gcc-11 also cannot compile numkong's AVX512-FP16 kernels, so point
CC/CXXat gcc-12. A post-buildobjdumpcheck fails the job if the binary ever requires newer thanGLIBC_2.35again.Changes
runs-ontoubuntu-22.04gcc-12/g++-12Test plan