Skip to content

release-linux: pin runner to ubuntu-22.04 and guard the glibc baseline - #388

Open
faisalahmedsifat wants to merge 1 commit into
pacifio:0.4.0from
faisalahmedsifat:faisal/fix-linux-release-glibc
Open

faisalahmedsifat wants to merge 1 commit into
pacifio:0.4.0from
faisalahmedsifat:faisal/fix-linux-release-glibc

Conversation

@faisalahmedsifat

Copy link
Copy Markdown

Summary

Built on ubuntu-latest (24.04, glibc 2.39), the release binary refuses to start on 22.04-based distros (Pop!_OS 22.04, Mint 21): the loader fails with GLIBC_2.38 / GLIBC_2.39 not found even though the package installs fine. glibc is backward-compatible only, so build on the oldest supported Ubuntu (22.04, glibc 2.35) to stay runnable everywhere newer.

Jammy's default gcc-11 also cannot compile numkong's AVX512-FP16 kernels, so point CC/CXX at gcc-12. A post-build objdump check fails the job if the binary ever requires newer than GLIBC_2.35 again.

Changes

  • Pin runs-on to ubuntu-22.04
  • Install and use gcc-12 / g++-12
  • Add a glibc baseline guard after the build

Test plan

  • Confirm the Linux release workflow still packages successfully on the pinned runner
  • Confirm the produced binary does not require symbols newer than GLIBC_2.35

Built on ubuntu-latest (24.04, glibc 2.39), the release binary refuses
to start on 22.04-based distros (Pop!_OS 22.04, Mint 21): the loader
fails with GLIBC_2.38/2.39 not found even though the package installs
fine. glibc is backward-compatible only, so build on the oldest
supported Ubuntu (22.04, glibc 2.35) to stay runnable everywhere newer.

Jammy's default gcc-11 also cannot compile numkong's AVX512-FP16
kernels, so point CC/CXX at gcc-12. A post-build objdump check fails
the job if the binary ever requires newer than GLIBC_2.35 again.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 77acf4c8-1c7b-4273-9f6f-468c7e44affd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant