Repository navigation
Conversation
CodeRabbit had no config file and ran on defaults, which only auto-review PRs whose base is the default branch. Atlas PRs target version branches (0.4.1, ...), so every contributor PR, fork or not, got "Review skipped" unless someone asked for a review by hand. - auto_review.base_branches: ".*" so every base branch is reviewed - turn off the docstring-coverage pre-merge check, which failed nearly every PR at its 80% default - skip generated files (lockfiles, Tauri gen, icon vendor, theme-key outputs, engine schemas) - path instructions drawn from CONTRIBUTING.md, CONTEXT.md and the vendor/atlas-engine notice rule, plus fork-safety checks for workflows - oxlint and clippy on, Biome and ESLint off; root docs as code guidelines
tests/ci-affected.test.ts requires every tracked file to be classified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds
.coderabbit.yaml. Until now CodeRabbit ran on its defaults, with no config file in the repo.Why?
CodeRabbit's defaults only auto-review PRs whose base is the default branch (
main). Atlas PRs target version branches, so contributor PRs were being skipped. #391 shows it:#394 was only reviewed because its author commented
@CodeRabbit review. Fork PRs were never the issue; the base branch was.How?
auto_review.base_branches: [".*"]. Every base branch is reviewed: version branches and one-off bases like0.3.0-stripalike.src-tauri/gen, icons, the vendored icon theme, thegenerate-theme-keys.mjsoutputs, and the engine's protocol and hook schemas. CI already checks each one against its generator.vendor/atlas-engine/ATLAS-CHANGES.md:atlas_profilefor directory namescreateSelectors/cn()/ feature-folder conventionsinvoke()callsvendor/atlas-engineTELEMETRY.mdupdated with telemetry changespull_request_target, secrets in fork jobs, unpinned actions)docs/. The general instruction points reviewers at them instead.scripts/ci-affected.mjs:.coderabbit.yamljoinsNON_RUST.ci-affected.test.tsrequires every tracked file to be classified.Keys were checked against CodeRabbit's schema and the current docs. Every
path_filters/path_instructionsglob was matched againstgit ls-filesand hits real files.CI cost: touching
scripts/ci-affected.mjsmakes the planner run all 32 Rust jobs for this PR. The change is one string in a list that no Rust job reads.After merge: depending on which branch CodeRabbit reads the config from, PRs already open may not pick this up until they merge
0.4.1back in. Setting the base-branch pattern.*in the CodeRabbit dashboard covers them now; where both are set, this file takes precedence.Fixes #
Checklist
ci-affected.test.tscovers the planner entry and fails without it.bun run lint,format:check,typecheckandtestall pass (2569 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01LLChyBTpyz2EVmMaCstCzd
Generated by Claude Code
Summary by CodeRabbit