Remove _test_check_names attribute from BaseBuildJobHelper#1726
Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom Oct 27, 2022
Merged
Conversation
For BaseBuildJobHelper, methods reporting the testing farm job statuses work with job configs passed in method arguments, therefore it doesn't make sense to store the results in the attribute and reuse it. Move this to TestingFarmJobHelper where we handle always only one test job and therefore it makes sense to store it there.
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
TomasTomecek
approved these changes
Oct 26, 2022
Contributor
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 57s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For BaseBuildJobHelper, methods reporting the testing farm job statuses work with job configs passed
in method arguments, therefore it doesn't make sense to store the results in the attribute and reuse it. Move this to TestingFarmJobHelper where we handle always only one test job and therefore it makes sense to store it there.
(Testing the changed functionality here, this affects only
report_status_to_all, otherwise, the changes look good so far...)Related to #1717
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END