Skip to content

Use configured failure message as suffix in comment for downstream jobs#2199

Merged
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:notify-downstream-jobs
Sep 26, 2023
Merged

Use configured failure message as suffix in comment for downstream jobs#2199
softwarefactory-project-zuul[bot] merged 1 commit intopackit:mainfrom
lbarcziova:notify-downstream-jobs

Conversation

@lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Sep 25, 2023

When creating issues/commenting in issue_repository, use the configured notifications.failure_comment.message in downstrem jobs. Followup of #2182


RELEASE NOTES BEGIN
You can now configure notifications.failure_comment.message also for downstream jobs, where the configured message will be used as an extension of the comment added by default by Packit.
RELEASE NOTES END

@softwarefactory-project-zuul

This comment was marked as outdated.

@lbarcziova
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

"""
configured_failure_message = (
f"\n\n---\n{configured_message}"
if (configured_message := job_config.notifications.failure_comment.message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that people can define this per job.

When creating issues/commenting in issue_repository, use the configured
notifications.failure_comment.message in downstrem jobs.
Followup of packit#2182
@lbarcziova lbarcziova force-pushed the notify-downstream-jobs branch from 468601a to 24c02fc Compare September 26, 2023 09:07
@lbarcziova lbarcziova added the mergeit Merge via Zuul label Sep 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

@lbarcziova
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d303b3e2b3ec41768e699e0e877fc1a5

✔️ pre-commit SUCCESS in 1m 47s
✔️ packit-service-tests SUCCESS in 2m 05s
✔️ packit-service-tests-openshift SUCCESS in 13m 00s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4fbcfd5f65754e23a60c1cc1e603b369

✔️ pre-commit SUCCESS in 1m 47s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1623608 into packit:main Sep 26, 2023
@lbarcziova lbarcziova deleted the notify-downstream-jobs branch September 26, 2023 10:03
lbarcziova added a commit to lbarcziova/packit.dev that referenced this pull request Sep 29, 2023
lbarcziova added a commit to lbarcziova/packit.dev that referenced this pull request Oct 3, 2023
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this pull request Oct 3, 2023
…age (#751)

Add note about downstream jobs for notifications.failure_comment.message

Related to packit/packit-service#2199

Reviewed-by: František Lachman <flachman@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants