Conversation
for more information, see https://pre-commit.ci
|
Build failed. ❌ pre-commit FAILURE in 1m 53s |
|
Hi @lbarcziova, could I please get initial review here? |
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
thanks a lot for the contribution! As I wrote in #2716 (comment), even after successful implementation, we will not be able to merge this right away, as we paused the work on this epic. So if you would like to contribute, feel free to pick some other issue, ideally comment there beforehand so that we can also provide pointers right away.
As for the contribution itself, it currently changes the API in place from Flask to FastAPI, but as the issue states, we would like to go with gradual change, keeping Flask endpoints up until the whole implementation is done. So it would need to be changed accordingly (taking inspiration from #2745).
|
|
||
|
|
||
| class BodhiUpdatesListResponse(BaseModel): | ||
| result: List | ||
| status: HTTPStatus |
There was a problem hiding this comment.
as this file representes DB models, this model should be rather placed in the appropriate API module with FastAPI implementation.
The structure also doesn't look correct, please refer to the current dictionary that is being returned, you can also try it out e.g. using staging Swagger UI
|
Closing this because of inactivity. |
2 participants
Fixes #2716
This PR shall move the work forward on the epic #2567
For reference, this builds on #2745