Expose the deployment as a tmt context#2988
Open
LecrisUT wants to merge 2 commits intopackit:mainfrom
Open
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly exposes the deployment name in the tmt context for downstream Testing Farm jobs. The change is simple and aligns with the goal of the PR. However, as noted in the PR description, tests are missing to verify this new functionality. I've added a comment regarding the missing test coverage, which is required by the repository's contributing guidelines.
Contributor
|
✔️ pre-commit SUCCESS in 1m 53s |
Signed-off-by: Cristian Le <git@lecris.dev>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 52s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #2987
RELEASE NOTES BEGIN
The packit deployment (
prodorstg) is now exposed in the tmt contextdeploymentRELEASE NOTES END