Mech command revamp#27
Conversation
| } | ||
|
|
||
| public boolean isVisionAligned() { | ||
| return true; //V2: return LimelightOB.getNoteAlignmentCommand(swerve) |
There was a problem hiding this comment.
What does this comment mean? Is it relevant?
There was a problem hiding this comment.
It just indicates what we will do in the future to populate this method. I can delete it for now since it serves no purpose currently.
There was a problem hiding this comment.
just replaced the comment with something more clear
|
|
||
| public class ReadyForIntake extends MechState { | ||
|
|
||
| public ReadyForIntake(LauncherSubsystem launcherSubsystem,AimingSubsystem aimingSubsystem,IntakeSubsystem intakeSubsystem) { |
There was a problem hiding this comment.
Can you add spaces after all the commas. Same comment in the call to super() below. And same comment for all similar files in this PR.
| public void setLauncherSpeed(LauncherMode mode) { | ||
| mLauncherSubsystem.setLauncherMode(mode); | ||
| } | ||
| @Override |
|
Should we merge #27 first, and then apply this PR as a delta? |
|
Sure, I don't mind since I branched from the Mech PR anyways so the rebase will be simple |
| @Override | ||
| public void handoffPosition(){ | ||
| mAimingSubsystem.setDesiredSetpoint(AimState.HANDOFF); | ||
| mLauncherSubsystem.setLauncherMode(LauncherMode.OFF); |
There was a problem hiding this comment.
Why is the launcher turned off while handoff, can't it keep charging?
|
|
||
| public void trapPosition(){} | ||
|
|
||
| public void resetEncoders() {} |
There was a problem hiding this comment.
is resetEncoders() being used? (I don't think it is)
3 participants
Made a couple of changes to the Mech PR issued by @chujiyang. It should work now