Skip to content

fixed the overwriting behavior of generate on empty calls - #42

Merged
OnixTech merged 1 commit into
mainfrom
41-bug-05-default-values-for-seed-in-generator
Aug 23, 2026
Merged

fixed the overwriting behavior of generate on empty calls#42
OnixTech merged 1 commit into
mainfrom
41-bug-05-default-values-for-seed-in-generator

Conversation

@semere-meb

@semere-meb semere-meb commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

Prevents MazeGenerator.generate from overwriting the seed to None on empty calls.

Fixes #41

Changes

  • MazeGenerator.generate uses the default seed if no argument is passed for the seed parameter, hence preventing it from being overwritten.
  • Updated the tests to reflect this change.

Testing

  • make lint passes locally
  • make test passes locally
  • Manually tested the behavior described above

Checklist

  • PR title follows <TICKET-ID>: short description
  • Linked to the correct issue (Fixes #... above)
  • No unrelated changes bundled into this diff
  • Updated README if this changes user-facing behavior (config keys, controls, etc.)

@semere-meb
semere-meb requested a review from OnixTech August 23, 2026 16:23
@semere-meb semere-meb self-assigned this Aug 23, 2026
@semere-meb semere-meb linked an issue Aug 23, 2026 that may be closed by this pull request
@semere-meb
semere-meb force-pushed the 41-bug-05-default-values-for-seed-in-generator branch from be5ce3f to c589240 Compare August 23, 2026 17:04

@OnixTech OnixTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@OnixTech
OnixTech merged commit 5fdd725 into main Aug 23, 2026
2 checks passed
@semere-meb
semere-meb deleted the 41-bug-05-default-values-for-seed-in-generator branch August 23, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG-05: default values for seed in generator

2 participants