Skip to content

12: config loaded correctly with comments stripped off - #78

Merged
semere-meb merged 2 commits into
mainfrom
12-cfg-01-json-with-comments-config-loader
Aug 20, 2026
Merged

12: config loaded correctly with comments stripped off#78
semere-meb merged 2 commits into
mainfrom
12-cfg-01-json-with-comments-config-loader

Conversation

@semere-meb

@semere-meb semere-meb commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

Reads config file, strips comment lines, and return Config object.

Closes #12

Changes

  • simplified pydantic model (Config) to be more declarative
  • parser cleans the config and hands off the json config to pydantic for validation
  • returns a valid Config data.

Testing

  • make lint passes locally
  • make test passes locally (check N/A below if no tests exist yet for this area)
  • Manually tested the behavior described above
  • N/A — no automated tests apply to this change yet

Checklist

  • PR title follows <TICKET-ID>: short description
  • Linked to the correct issue (Fixes #... above)
  • No unrelated changes bundled into this diff
  • Updated docs/design/ if this changes config shape, architecture, or a game-design decision
  • Updated README if this changes user-facing behavior (config keys, controls, etc.)

@semere-meb
semere-meb requested a review from rustyzzz August 20, 2026 01:15
@semere-meb semere-meb self-assigned this Aug 20, 2026
@semere-meb semere-meb linked an issue Aug 20, 2026 that may be closed by this pull request
@semere-meb
semere-meb merged commit da47f9f into main Aug 20, 2026
2 checks passed
@semere-meb
semere-meb deleted the 12-cfg-01-json-with-comments-config-loader branch August 20, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CFG-01: JSON-with-comments config loader

1 participant