Merged
Conversation
johannes-moegerle
force-pushed
the
jj-coupling
branch
from
03fa30d to
93987cc
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new RydbergStateAlkalineJJ class to represent alkaline Rydberg states using JJ coupling, which is specifically intended for high-l (l ≥ 5) states where singlet and triplet quantum defects are nearly identical.
Key changes:
- Introduced
RydbergStateAlkalineJJclass for alkaline atoms with JJ coupling scheme - Added appropriate import for
AngularKetJJin the rydberg_state module - Exported the new class in the package's
__init__.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/rydstate/rydberg_state.py |
Added new RydbergStateAlkalineJJ class (lines 307-380) with initialization, angular/radial properties, and quantum defect calculation. Also added AngularKetJJ import (line 11) |
src/rydstate/__init__.py |
Added RydbergStateAlkalineJJ to imports and __all__ list to expose the new class in the public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
pairinteraction/database-sqdt#16