Add opt-in Jackson Blackbird optimization to ObjectMappers#3534
Open
parker89 wants to merge 1 commit into
Open
Add opt-in Jackson Blackbird optimization to ObjectMappers#3534parker89 wants to merge 1 commit into
parker89 wants to merge 1 commit into
Conversation
Generate changelog in
|
mpritham
reviewed
Jul 9, 2026
| } | ||
|
|
||
| /** Like {@link #newServerSmileMapper()}, optionally enabling Jackson optimization modules (Blackbird). */ | ||
| public static SmileMapper newServerSmileMapper(boolean useOptimizations) { |
Contributor
There was a problem hiding this comment.
Did you have other optimizations in mind down the line?
I wonder if we should name this something like "newSingleInstantiatedServerSmileMapper" or something to make it clear that this should not be called multiple times, and then enable blackbird by default for this case.
Maybe we can write an errorprone check(? e.g. only created in a final variable in a class - though this is a bit restrictive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in Jackson Blackbird support to
ObjectMappers(off by default).ObjectMapperOptimizations.createModules(boolean)plus new server/client mapper overloads registerBlackbirdModuleonly when explicitly requested.