[break] Consistently resolve binary aliases in service endpoints#128
[break] Consistently resolve binary aliases in service endpoints#128pkoenig10 wants to merge 1 commit into
Conversation
|
I think it is a bit strange to resolve binary types at all. Aliases in conjure provide type safety, but by resolving binary aliases we're explicitly removing the type safety. Given that there is only a single type of a streaming request/response, I think it would make more sense to not resolve binary types meaning that only the primitive |
|
You're right that its strange. I think that we should think through the implications of this change and what we want the end outcome to be. Its worth taking a step back and thinking through the wider usage of |
## Before this PR For jersey service endpoints returning a binary alias type, the return type was resolved correctly (to `StreamingOutput` or `Response`) but the correct `@Produces` annotation was not applied. ## After this PR The `@Produces` annotation is applied to endpoints returning binary alias types. See discussion about resolving binary types in #128.
|
Closing this as it's been stale for a while. |
See #99 (comment)
cc @iamdanfox @ferozco
Before this PR
Binary alias return types are resolved but binary alias parameters are not.
After this PR
Both binary alias return types and parameters are resolved.