Make management-port required#282
Open
akshan-main wants to merge 1 commit into
Open
Conversation
Generate changelog in
|
86ea9ce to
5049cc3
Compare
Author
Member
|
Thanks for the PR! I do want to land this, but since it's a breaking change I'd like to hold off to bundle it with other breaks. |
Author
|
@sfackler Sounds good, thanks! I’ll leave this open and can rework it whenever it makes sense to bundle the breaking changes. Also, I’m trying to get more involved in OSS and would be glad to take on more substantive work if there are issues where an outside contributor could be useful. I’m especially interested in Rust server internals, async/concurrency, config/runtime behavior. Feel free to tag me, and I can help by contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
management-portwas optional. If left out, status endpoints got served on the main port. That fallback existed for the migration to a dedicated management port, which is done. See #281.After this PR
==COMMIT_MSG==
management-portis required in install config.==COMMIT_MSG==
Possible downsides?
Breaking config change. Any service still omitting
management-portwill fail to start until it's added. Also updated the example in the crate docs so it doesn't show a stale config without the field.