Skip to content

Make management-port required#282

Open
akshan-main wants to merge 1 commit into
palantir:developfrom
akshan-main:require-management-port
Open

Make management-port required#282
akshan-main wants to merge 1 commit into
palantir:developfrom
akshan-main:require-management-port

Conversation

@akshan-main

@akshan-main akshan-main commented May 7, 2026

Copy link
Copy Markdown

Before this PR

management-port was optional. If left out, status endpoints got served on the main port. That fallback existed for the migration to a dedicated management port, which is done. See #281.

After this PR

==COMMIT_MSG==
management-port is required in install config.
==COMMIT_MSG==

Possible downsides?

Breaking config change. Any service still omitting management-port will fail to start until it's added. Also updated the example in the crate docs so it doesn't show a stale config without the field.

@changelog-app

changelog-app Bot commented May 7, 2026

Copy link
Copy Markdown

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

management-port is now required in install configuration.

Check the box to generate changelog(s)

  • Generate changelog entry

@akshan-main akshan-main force-pushed the require-management-port branch from 86ea9ce to 5049cc3 Compare May 7, 2026 22:52
@akshan-main

akshan-main commented May 7, 2026

Copy link
Copy Markdown
Author

@sfackler saw your issue #281 and thought I could contribute

@sfackler

Copy link
Copy Markdown
Member

Thanks for the PR! I do want to land this, but since it's a breaking change I'd like to hold off to bundle it with other breaks.

@akshan-main

Copy link
Copy Markdown
Author

@sfackler Sounds good, thanks! I’ll leave this open and can rework it whenever it makes sense to bundle the breaking changes.

Also, I’m trying to get more involved in OSS and would be glad to take on more substantive work if there are issues where an outside contributor could be useful. I’m especially interested in Rust server internals, async/concurrency, config/runtime behavior. Feel free to tag me, and I can help by contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants