Skip to content

ProjectScaffold-ize#11

Merged
palladin merged 1 commit into
palladin:masterfrom
sideeffffect:master
Oct 17, 2016
Merged

ProjectScaffold-ize#11
palladin merged 1 commit into
palladin:masterfrom
sideeffffect:master

Conversation

@sideeffffect

@sideeffffect sideeffffect commented Oct 15, 2016

Copy link
Copy Markdown
Contributor

this adds support for cool stuff, like packaging, tests, etc

it might seem that there are many changes, but actually all that I've done is to remove trailing whitespace

you can enable Travis and AppVeyor -- do it even before the merge

this adds support for cool stuff, like packaging, tests, etc
@palladin palladin merged commit 04a9b2f into palladin:master Oct 17, 2016
@palladin

Copy link
Copy Markdown
Owner

Thanks!

@sideeffffect

sideeffffect commented Oct 17, 2016

Copy link
Copy Markdown
Contributor Author

can you please enable both Travis and AppVeyor for this repo?

Here is howto for
Travis: https://travis-ci.org/getting_started
and
AppVeyor: https://www.appveyor.com/docs/

or just ask me if you need help with this ;)

and thanks for such a quick merge!

@palladin

Copy link
Copy Markdown
Owner

@sideeffffect

Copy link
Copy Markdown
Contributor Author

why nessos and not palladin on AppVeyor, if you don't mind me asking?
if it's not palladin, then we have to fix the Readme

@palladin

palladin commented Oct 17, 2016

Copy link
Copy Markdown
Owner

I tried to change the account name to palladin and I broke all the links of the other hosted projects.
(btw nessos is the name of my company)

@sideeffffect

Copy link
Copy Markdown
Contributor Author

fair enough
I've created fix #12
but I see that you have configured only Travis as a PR guard -- can you please make AppVeyor a mandatory pass for PRs to be mergable?

@palladin

Copy link
Copy Markdown
Owner

I think it is ready.

@sideeffffect

Copy link
Copy Markdown
Contributor Author

I don't think so, if you look at #13 , only Travis got triggered
perhaps you have to change something in settings of the repository

http://help.appveyor.com/discussions/questions/203-auto-run-tests-on-pull-requests

https://stackoverflow.com/questions/32607885/appveyor-doesnt-update-github-pull-request-with-the-build-status

@palladin

Copy link
Copy Markdown
Owner

Hmmm, the webhook for appveyor is setup correctly and in Recent Deliveries I found your pull request "Small Readme change".

@palladin

Copy link
Copy Markdown
Owner

I think it is ok now
#14

@sideeffffect

Copy link
Copy Markdown
Contributor Author

yep, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants