Draft
Conversation
noma
requested changes
Oct 30, 2020
panau161
force-pushed
the
tbb_pthread
branch
4 times, most recently
from
96e3e26 to
1fda3ed
Compare
panau161
force-pushed
the
tbb_pthread
branch
10 times, most recently
from
8a76690 to
a104fc9
Compare
panau161
force-pushed
the
tbb_pthread
branch
from
b59ff61 to
3e7fe00
Compare
panau161
force-pushed
the
tbb_pthread
branch
4 times, most recently
from
f6fea4c to
8acf01b
Compare
Apparently i was overly optimistic and PyOpenCL memory usage skyrockets when having multiple contexts. This keeps the new code, but reverts the behaviour to one LLVM context. The new code is still useful since it isolates the LLVM code. This should eventually be resolved by having separate LLVM compilation thread(s).
…ix/pocl into compilerOptions_allowSpaces
At this stage, the 'tbb' device is a renamed copy of the 'pthread' device.
- change header include order to alphabetical
- always use PoCL vendor string and ID
- add a warning if the user would like to use more than one tbb device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal draft pull request