Open
Conversation
e1e22b3 to
aa40553
Compare
aa40553 to
d18a4e6
Compare
|
Looks good to me. One last idea I'll throw out - libhc could be an installable package that we just list as a dependency - like how PANDA depends on wintrospection. |
|
Hey @jamcleod I just created a Debian Package for LibHC, and I added CI/CD Could you please merge my PR and fix the hypercalls? But the advantage of Debian packages is that you no longer need sub-modules; just use curl to get the latest header. I have been using the header on my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed on slack, moves hypercall.h to its own separate repo included as a submodule. I've tested that it has built and I see no reasons the changes could successfully build while changing behavior, so no in-depth testing. Let me know if for some reason this seems incorrect.