Skip to content

Conversation

@dattpatel123
Copy link

@dattpatel123 dattpatel123 commented Dec 21, 2025

Before when you pass an empty series into the pd.Series.round() it would raise a type error because an empty series is an object type. Now it doesn’t raise that error. It will raise that error only when an object or string type is passed. It now checks if it the series is a true string or object before raising error. I also added some new test cases to make sure the fix doesn’t mess up the function and that it handles empty series. Might have made mistakes as it’s my first time contributing!

@sanchit122006
Copy link

sanchit122006 commented Dec 21, 2025

Are you providing unreviewed code of ai, you don't provide any info in description about your code change

@sanchit122006
Copy link

@dattpatel123 why you add slashes in reference checks add cross mark on closes columns or another's if you tested the code.
Screenshot_20251221_113114_Chrome

@sanchit122006
Copy link

@dattpatel123 Replace this "doc/source/whatsnew/v3.0.rst" as you changed this file, untick all code checks passed as you have 1 failing check why are you so dumb 🙂

@sanchit122006
Copy link

I think you have lots of mistakes in your code please review the code first, otherwise we have to give you ai slop label !!

@dattpatel123 dattpatel123 deleted the fix-issue-#63444 branch December 21, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Rounding of an empty Series should return empty Series

2 participants