Refactor match result handling and enhance tournament logic - #13
Merged
Merged
Conversation
pangwangshu
commented
Jul 3, 2026
pangwangshu
commented
Owner
- Updated the match result state to include winner and loser team attributes.
- Modified the MatchupPredictor to load winner and loser teams from match data.
- Enhanced TournamentStructureResolver to resolve winner and loser slots based on match results.
- Added utility methods in WorldRankingTournamentSimulator to handle known match pairs.
- Updated tests to verify the correct handling of match results, including penalty outcomes and known fixtures.
- Adjusted the logic for predicting matchup candidates to respect known match results.
- Updated the match result state to include winner and loser team attributes. - Modified the MatchupPredictor to load winner and loser teams from match data. - Enhanced TournamentStructureResolver to resolve winner and loser slots based on match results. - Added utility methods in WorldRankingTournamentSimulator to handle known match pairs. - Updated tests to verify the correct handling of match results, including penalty outcomes and known fixtures. - Adjusted the logic for predicting matchup candidates to respect known match results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.