Add superadmin-configurable site messages for auth pages and dashboard - #41
Merged
Conversation
Lets superadmins set an optional banner on the login/register pages and a separate one on the dashboard, each with its own on/off toggle, directly from the admin settings page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe PR adds superadmin-controlled login and dashboard messages. The settings form stores message text and enablement flags. Login, registration, and dashboard pages retrieve enabled messages and render them with ChangesConfigurable site messages
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Superadmin
participant AdminSettingsClient
participant SettingsAPI as /api/admin/settings
participant LoginPage
participant DashboardPage
participant SiteMessageBanner
Superadmin->>AdminSettingsClient: edit site-message settings
AdminSettingsClient->>SettingsAPI: PATCH settings
LoginPage->>LoginPage: getLoginMessage()
DashboardPage->>DashboardPage: getDashboardMessage()
LoginPage->>SiteMessageBanner: render login message
DashboardPage->>SiteMessageBanner: render dashboard message
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/admin/settingsunder a new "Site messages" card, gated to superadmins both client- and server-side (same pattern as the existingregistrationEnabledsetting)appSettingskey-value table, no migration neededTest plan
tsc --noEmitandeslintpass on all changed files/login,/register, and/(dashboard)PATCH /api/admin/settingscall with a non-superadmin session is rejected with 403🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes