refactor: migrate XML (de)serialization from quick-xml to instant-xml#156
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 75.03% 74.93% -0.11%
==========================================
Files 30 30
Lines 725 718 -7
==========================================
- Hits 544 538 -6
+ Misses 181 180 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paolobarbolini
force-pushed
the
instant-xml-migration
branch
from
425dfae to
180dfab
Compare
Performance improves by 1.2x–2x across all measured benchmarks. Also removes some hacky code we had, since serde does not pair well with XML.
paolobarbolini
force-pushed
the
instant-xml-migration
branch
from
180dfab to
4c958dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick-xmlrelies on serde, which does not map well with xml. This switches toinstant-xml, which uses it's own system for serialization and deserialization. It doesn't support streaming decoding, but I hope people don't mind too much.I'll test this more in the following days.