Simplify Knapper agent sessions - #37
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
#AI-Automation CI passed without failures on Node 20, 22, and 24, including the packaged-install gate. Review-driven changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Replace multi-workspace/agent session model with a single managed session in Knapper
workspaceHandle/agentHandle; session lifecycle is now managed viaobsidian_session_open,obsidian_session_release, andobsidian_session_reset.ActivityGuardin activity-guard.ts as a cross-process coordination primitive that enforces a single active session at a time, surfacingKNAPPER_BUSYwithretryAfterMsto competing callers.ToolRegistry(was configurable concurrency); status-only tools bypass activity acquisition.obsidian_toolsets_updatetool; the MCP tool surface is now fixed at initialization with a default set of toolsets (core, ui, telemetry, plugin-dev, editor).0.7.0-beta.1and updates all documentation, skills, agent guides, and test scripts to reflect session semantics.workspaceHandleor relying on dynamic toolset updates or multi-workspace isolation will break.Macroscope summarized 9d6a978.