Harden single-session lifecycle - #39
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
#AI-Automation CI passed without failures on Node 20, 22, and 24, including the packaged-install gate. Review-driven changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address promotion review findings before the 0.7.0-beta.1 release.
Verification
Note
Harden single-session lifecycle with deadline-based timeouts and telemetry archiving
makeReadyandopenIsolatedin session.ts now propagate a single unified deadline across session creation, wait, and restart steps instead of independent per-step timeouts.selectSingletonDescriptorretains them somakeReadycan attempt a restart instead of creating a duplicate session.obsidian_session_openarchives the previous session's telemetry to the quarantined root on reset and returns the archive path inarchivedTelemetry.CallLocknow log a warning, emit an audit event, and return a structured error result.ActivityGuardin activity-guard.ts now rejectsidleTimeoutMs < 1000at construction time and allows heartbeat intervals as low as 250 ms.Macroscope summarized 4b547f2.