Skip to content

Harden single-session lifecycle - #39

Merged
slate-rehm merged 2 commits into
devfrom
feature/release-review-fixes
Aug 8, 2026
Merged

Harden single-session lifecycle#39
slate-rehm merged 2 commits into
devfrom
feature/release-review-fixes

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Address promotion review findings before the 0.7.0-beta.1 release.

  • Recover failed descriptors instead of creating a second managed target.
  • Enforce one timeout budget across restart and reset stages.
  • Keep heartbeat intervals below the activity expiry window.
  • Archive telemetry when reset quarantines a session.
  • Restore structured error and audit handling for FIFO admission timeouts.
  • Ignore generated fixture settings data.

Verification

  • npm run check
  • npm run typecheck
  • npm test: 468 tests
  • npm run smoke
  • npm run acceptance: 20 checks
  • npm run workspaces: 7 checks
  • live settings E2E: 92 checks

Note

Harden single-session lifecycle with deadline-based timeouts and telemetry archiving

  • makeReady and openIsolated in session.ts now propagate a single unified deadline across session creation, wait, and restart steps instead of independent per-step timeouts.
  • Failed session descriptors are no longer filtered out during selection; selectSingletonDescriptor retains them so makeReady can attempt a restart instead of creating a duplicate session.
  • obsidian_session_open archives the previous session's telemetry to the quarantined root on reset and returns the archive path in archivedTelemetry.
  • Tool invocations in registry.ts that fail before acquiring the CallLock now log a warning, emit an audit event, and return a structured error result.
  • ActivityGuard in activity-guard.ts now rejects idleTimeoutMs < 1000 at construction time and allows heartbeat intervals as low as 250 ms.

Macroscope summarized 4b547f2.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0097cef-808b-4a8b-9ffc-a8ee537b25ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Comment thread src/tools/session.ts
@slate-rehm

Copy link
Copy Markdown
Collaborator Author

#AI-Automation

CI passed without failures on Node 20, 22, and 24, including the packaged-install gate.

Review-driven changes:

  • Recovered failed descriptors instead of creating a second target.
  • Shared one absolute timeout deadline across reset and startup stages.
  • Kept heartbeat timing safely below the activity expiry window.
  • Archived managed-session telemetry during reset quarantine.
  • Restored structured errors and audit events for FIFO admission timeouts.
  • Added regression coverage for failed descriptor reuse and short activity windows.
  • Ignored generated settings-fixture data.
  • Resolved the Macroscope review thread.

@slate-rehm
slate-rehm merged commit 20e8954 into dev Aug 8, 2026
6 checks passed
@slate-rehm
slate-rehm deleted the feature/release-review-fixes branch August 8, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant