Harden single-session ownership before release - #40
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
#AI-Automation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the stateless single-session release after promotion review.
Verification
Note
Harden single-session ownership to prevent reclamation during active operations
ActivityGuard.acquirenow only reclaims an existing record when the owner process is dead or whenactiveOperationsis 0 and the record is expired, preventing mid-operation ownership theftactiveOperationsis set to 1 on acquire and reset to 0 oncomplete;completestops the heartbeat and invokes a newonErrorcallback on failureobsidian_doctorandobsidian_create_vaultnow branch onctx.targetKind === 'isolated'instead of checkingconfig.sessionId, aligning provisioning logic with the active target kindobsidian_create_vault,obsidian_unregister_vault, andobsidian_link_pluginis updated to mark them as destructive and not read-onlyobsidian_doctorreports the correct active targetonErrorrather than being silently droppedMacroscope summarized 07ea647.