Skip to content

Simplify Knapper to a fixed 20-tool surface - #43

Merged
slate-rehm merged 1 commit into
devfrom
agent/fixed-20-tool-surface
Aug 16, 2026
Merged

Simplify Knapper to a fixed 20-tool surface#43
slate-rehm merged 1 commit into
devfrom
agent/fixed-20-tool-surface

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Fix the public MCP surface at 20 tools.
  • Require an explicit Git-ignored vault path for obsidian_open.
  • Keep one private Obsidian profile, one vault, and one optional plugin active.
  • Add stable window IDs for main windows and popouts.
  • Keep logs and eval, including popout attribution.
  • Queue one-shot prompt responses without opening a dialog.
  • Dismiss unsupported alert and confirm dialogs.
  • Remove graph, canvas, attachment, toolset, and compatibility workflows.
  • Update local plugin metadata and release version to 0.7.0.

Validation

  • npm run check
  • npm run typecheck
  • npm test — 475 tests passed
  • npm run build
  • npm run smoke
  • npm run acceptance — 21 checks passed

The plugin-specific live dev-cycle check skips when no PLUGIN_SOURCE_DIR and PLUGIN_ID are set.

Note

Simplify Knapper to a fixed 20-tool surface targeting one private development vault

  • Replaces the previous multi-session, toolset-configurable surface with a fixed set of 20 public tools defined in PUBLIC_TOOL_NAME_SET; all other tools are hidden from MCP clients.
  • Introduces obsidian_open (requires vaultPath, optional pluginDir) and obsidian_close as the sole session lifecycle tools, replacing obsidian_session_open, obsidian_session_release, and related tools.
  • obsidian_dev_cycle now resolves the linked plugin automatically from the active session and no longer accepts manual pluginId or vault parameters.
  • Adds window-scoped automation: browser_click and browser_handle_dialog are first-class tools; snapshot refs, telemetry records, and eval calls are all optionally scoped by windowId.
  • Removes CLI flags --cdp-url, --vault, --toolsets, and --target-match and drops the authorize/revoke/authorizations subcommands from the CLI.
  • Introduces strict vault path validation via prepareDevelopmentPaths: vault must be inside the plugin Git repo, Git-ignored, non-symlinked, and absolute.
  • Risk: Any integrations relying on toolset configuration, legacy session tools, or removed CLI flags will break; the tool surface is now exactly 20 tools and acceptance/smoke tests enforce this count.

Macroscope summarized b63e8a2.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 74ae807f-d5c9-426c-89e7-11b20f16cbb3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Aug 16, 2026

Copy link
Copy Markdown

Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting).

This review would cost an estimated $13.84, which exceeds your per-review limit of $10.00.

The top 3 files driving up this estimate:

File Diff Size Estimate
README.md 33.23KB $1.66
scripts/acceptance.ts 18.61KB $0.93
SECURITY.md 15.67KB $0.78

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude the file(s) above from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

@slate-rehm
slate-rehm merged commit d1ee3e3 into dev Aug 16, 2026
6 checks passed
@slate-rehm
slate-rehm deleted the agent/fixed-20-tool-surface branch August 16, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant