Skip to content

chore(semark): align validation docs with local checker - #11

Open
slate-rehm wants to merge 1 commit into
masterfrom
chore/semark-audit-corrections
Open

slate-rehm wants to merge 1 commit into
masterfrom
chore/semark-audit-corrections

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document Semark validation, scope, and audit label mapping in AGENTS.md.
  • Run pnpm semark:check through pnpm check so local runs match CI enforcement.
  • Remove duplicate Semark steps from CI and release workflows.
  • Simplify the README development commands.

Test plan

  • pnpm check
  • pnpm semark:check

Made with Cursor

Changes

  • Documented Semark validation, scope, and audit label mapping in AGENTS.md.
  • Added pnpm semark:check to pnpm check.
  • Removed duplicate Semark checks from CI and release workflows.
  • Removed the separate Semark command from the README development checks.

Validation

  • pnpm check
  • pnpm semark:check

Document the check-semark.mjs setup, checker scope, and audit label mapping
in AGENTS.md. Run Semark validation through pnpm check so local runs match CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 9420cb01-cfe9-4e90-983e-99e7fcd5760e

📥 Commits

Reviewing files that changed from the base of the PR and between aec9dfe and a129b48.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • AGENTS.md
  • README.md
  • package.json
💤 Files with no reviewable changes (3)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • README.md

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The shared check script now runs pnpm semark:check. The CI and release workflows no longer run the checker as a separate step. Repository guidance defines Semark validation scope and audit categories. The README removes the standalone command from development checks.

Changes

Semark validation integration

Layer / File(s) Summary
Semark guidance and audit rules
AGENTS.md
Defines the Semark validation command, excludes the Oxlint plugin, specifies TypeScript file scope and .d.ts handling, and maps checker labels to audit categories.
Shared validation and workflow wiring
package.json, .github/workflows/ci.yml, .github/workflows/release.yml
Adds pnpm semark:check to the shared check script and removes separate Semark checker steps from CI and release validation.
Development check documentation
README.md
Removes the standalone pnpm semark:check command from the documented development checks.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a129b

This PR aligns documented validation with local and CI checks while removing duplicate workflow steps and simplifying development commands; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Semark validation documentation alignment and matches the main changes to route validation through the local checker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant