Skip to content

docs(semark): align skill guidance with check-semark.mjs - #12

Merged
slate-rehm merged 1 commit into
masterfrom
t3code/align-semark-skill-guidance
Sep 3, 2026
Merged

slate-rehm merged 1 commit into
masterfrom
t3code/align-semark-skill-guidance

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align semark-protocol skill modules with scripts/check-semark.mjs: Oxlint plugin is optional, source roots match the checker, audit categories map to checker labels, and block-body callable scope is documented.
  • Add a Semark overlay in AGENTS.md for this repository's local validator.
  • Run pnpm semark:check inside pnpm check and remove duplicate CI workflow steps.

Test plan

  • pnpm check
  • pnpm semark:check

Made with Cursor

Release notes

  • Align Semark skill guidance with scripts/check-semark.mjs.
  • Make the Oxlint plugin optional.
  • Align Semark source roots with checker behavior.
  • Map audit categories to checker labels.
  • Define block-body callable scope.
  • Add Semark guidance to AGENTS.md.
  • Run pnpm semark:check from pnpm check.
  • Remove duplicate Semark checks from CI and release workflows.
  • Validate with pnpm check and pnpm semark:check.

Correct Oxlint plugin guidance, source scope, audit labels, and method
signature checker scope. Run Semark validation inside pnpm check.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: cc820bf6-0196-4e23-a855-a96ae9333e42

📥 Commits

Reviewing files that changed from the base of the PR and between aec9dfe and 88657c9.

📒 Files selected for processing (9)
  • .agents/skills/semark-protocol/references/audit.md
  • .agents/skills/semark-protocol/references/install.md
  • .agents/skills/semark-protocol/rules/method-signature.md
  • .agents/skills/semark-protocol/rules/source-scope.md
  • .agents/skills/semark-protocol/rules/validation.md
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • AGENTS.md
  • package.json
💤 Files with no reviewable changes (2)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The changes align Semark rule scope and method-signature guidance, define local validation and audit mappings, add Semark validation to pnpm check, update repository instructions, and remove separate workflow invocations.

Changes

Semark validation alignment

Layer / File(s) Summary
Semark rule boundaries
.agents/skills/semark-protocol/rules/*
Source applicability now uses configured TypeScript roots. Method-signature guidance covers generators, block-bodied function expressions, assigned arrows, hooks, and exported callables.
Validation and audit guidance
.agents/skills/semark-protocol/references/*, .agents/skills/semark-protocol/rules/validation.md
The repository-local checker is required. Oxlint integration is optional. Requirements outside checker boundaries remain part of repository validation. Checker labels now map to audit categories with fallback categories.
Repository validation wiring
package.json, AGENTS.md, .github/workflows/release.yml
pnpm check runs pnpm semark:check. Repository instructions document this path. The release workflow no longer runs a separate Semark check.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 88657

This PR aligns repository guidance and validation wiring without any actionable merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary documentation change: aligning Semark skill guidance with scripts/check-semark.mjs. It also remains consistent with the related validation integra…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title clearly and concisely describes the primary documentation change: aligning Semark skill guidance with scripts/check-semark.mjs. It also remains consistent with the related validation integration changes.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@slate-rehm

Copy link
Copy Markdown
Contributor Author

#AI-Automation

  • No CI or CodeRabbit fixes were required; all checks passed on the first run.

@slate-rehm
slate-rehm merged commit d4cfca3 into master Sep 3, 2026
2 checks passed
@slate-rehm
slate-rehm deleted the t3code/align-semark-skill-guidance branch September 3, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant